Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated boto3 parameter #2443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove deprecated boto3 parameter #2443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/fragments/2443-boto-final-clean.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
breaking_changes:
- module_utils.botocore - drop deprecated ``boto3`` parameter for ``get_aws_region()`` and ``get_aws_connection_info()``, this parameter has had no effect since release 4.0.0 (https://github.com/ansible-collections/amazon.aws/pull/2443).
16 changes: 0 additions & 16 deletions plugins/module_utils/botocore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,15 +228,7 @@ def _aws_region(params: Dict) -> Optional[str]:

def get_aws_region(
module: AnsibleAWSModule,
boto3: Optional[bool] = None,
) -> Optional[str]: # pylint: disable=redefined-outer-name
if boto3 is not None:
module.deprecate(
"get_aws_region(): the boto3 parameter will be removed in a release after 2025-05-01. "
"The parameter has been ignored since release 4.0.0.",
date="2025-05-01",
collection_name="amazon.aws",
)
try:
return _aws_region(module.params)
except AnsibleBotocoreError as e:
Expand Down Expand Up @@ -302,15 +294,7 @@ def _aws_connection_info(params: Dict) -> Tuple[Optional[str], Optional[str], Di

def get_aws_connection_info(
module: AnsibleAWSModule,
boto3: Optional[bool] = None,
) -> Tuple[Optional[str], Optional[str], Dict]: # pylint: disable=redefined-outer-name
if boto3 is not None:
module.deprecate(
"get_aws_connection_info(): the boto3 parameter will be removed in a release after 2025-05-01. "
"The parameter has been ignored since release 4.0.0.",
date="2025-05-01",
collection_name="amazon.aws",
)
try:
return _aws_connection_info(module.params)
except AnsibleBotocoreError as e:
Expand Down
Loading