Migrate to REST API. Removed 'update' state #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since skydive commit 7dc363cc25 (in master, not released yet), node and edge APIs are exposed also with a REST API. Using this API makes more sense for this modules, as it only make one operation and do not need to stay connected to receive messages (as websockets do). This PR also uses the PATCH method (still a PR: skydive-project/skydive#2263) to update nodes/edges generating a list of JSON patches for the keys found in the metadata key. Keys defined in metadata will modify the stored node/edge. Other metadata values in the stored node/edge will remaing unmodified. 'update' state is removed, so modules behave similar to others ansible modules ('file' for example). Now 'present' state will create or update nodes/edges. Breaking change that should be reported to users.
|
@lebauce @safchain @network Any thoughts on this PR from @adrianlzt @adrianlzt I notice a rebase is needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since skydive commit 7dc363cc25 (in master, not released yet), node and
edge APIs are exposed also with a REST API.
Using this API makes more sense for this modules, as it only make one
operation and do not need to stay connected to receive messages (as
websockets do).
This PR also uses the PATCH method (still a PR:
skydive-project/skydive#2263) to update
nodes/edges generating a list of JSON patches for the keys found in the
metadata key.
Keys defined in metadata will modify the stored node/edge.
Other metadata values in the stored node/edge will remaing unmodified.
'update' state is removed, so modules behave similar to others ansible
modules ('file' for example).
Now 'present' state will create or update nodes/edges.
Breaking change that should be reported to users.
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION