Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to REST API. Removed 'update' state #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Migrate to REST API. Removed 'update' state #9

wants to merge 1 commit into from

Commits on Aug 7, 2020

  1. Migrate to REST API. Removed 'update' state 

    Since skydive commit 7dc363cc25 (in master, not released yet), node and
edge APIs are exposed also with a REST API.
Using this API makes more sense for this modules, as it only make one
operation and do not need to stay connected to receive messages (as
websockets do).

This PR also uses the PATCH method (still a PR:
skydive-project/skydive#2263) to update
nodes/edges generating a list of JSON patches for the keys found in the
metadata key.
Keys defined in metadata will modify the stored node/edge.
Other metadata values in the stored node/edge will remaing unmodified.

'update' state is removed, so modules behave similar to others ansible
modules ('file' for example).
Now 'present' state will create or update nodes/edges.
Breaking change that should be reported to users.
    @adrianlzt
    adrianlzt committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    a97688c View commit details
    Browse the repository at this point in the history