Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the community.docker collection #257

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update the community.docker collection #257

wants to merge 2 commits into from

Conversation

mcdonnnj
Copy link

Includes fixes related to psf/requests#6707 and docker/docker-py#3256

Fixes #256.

@mcdonnnj
Update the community.docker collection
6ebc825 
Version 3.10.2 is required to work with recent breaking changes in
psf/requests and docker/docker-py.

Signed-off-by: Nicholas McDonnell <[email protected]>
jsf9k
jsf9k approved these changes May 23, 2024
View reviewed changes
Copy link

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@mcdonnnj
Copy link
Author

mcdonnnj commented May 24, 2024 •
edited
Loading

The test failures appear to be a result of the version of ansible-core installed (2.17.0). This latest version of ansible-core has dropped support for module execution by Python 3.6, but the Docker image used for testing (docker.io/pycontribs/centos:8) has Python 3.6.8. I am not sure what image the maintainers would like to move to as there is no newer version of the docker.io/pycontribs/centos image available. The images that are available haven't been updated in three years which matches the repository.

@jsf9k
Copy link

jsf9k commented May 29, 2024

What can I do to help move this PR forward? I really need this fix.

This was referenced May 29, 2024
Open
Merged
@DChalcraft
Copy link

👍 for this

@konstruktoid
Copy link
Contributor

The test failures appear to be a result of the version of ansible-core installed (2.17.0). This latest version of ansible-core has dropped support for module execution by Python 3.6, but the Docker image used for testing (docker.io/pycontribs/centos:8) has Python 3.6.8. I am not sure what image the maintainers would like to move to as there is no newer version of the docker.io/pycontribs/centos image available. The images that are available haven't been updated in three years which matches the repository.

The hub images are available at https://hub.docker.com/r/pycontribs/centos/tags and I'm in the progress to write a PR to align CentOS with the rest of the images (using :latest and such).

@sebdanielsson
Copy link

Testing against CentOS doesn't really make sense since it has reached EOL? CentOS Stream 9 or AlmaLinux would make more sense, right?

@konstruktoid
Copy link
Contributor

yeah, my PR will use AlmaLinux

@konstruktoid konstruktoid mentioned this pull request May 31, 2024
Open
@konstruktoid
Copy link
Contributor

PR submitted

@jrgoldfinemiddleton
Copy link

You are a soldier!

@sbesson sbesson mentioned this pull request Jun 4, 2024
Merged
@ssbarnea ssbarnea added the bug Something isn't working label Jun 18, 2024
@mcdonnnj
Copy link
Author

@ssbarnea I do not believe tests will not pass for this PR until #257 (comment) is resolved. I'm happy to make any changes you'd like to move this PR forward.

@koralowiec koralowiec mentioned this pull request Jun 27, 2024
Open
3 tasks
@basil
Copy link

basil commented Nov 14, 2024

Any update on this PR?

@basil
Copy link

basil commented Nov 14, 2024

Looks like CI has been fixed as of #260?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

@jsf9k jsf9k jsf9k approved these changes

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker: doesn't work with requests-2.32.1
9 participants
@mcdonnnj @jsf9k @DChalcraft @konstruktoid @sebdanielsson @jrgoldfinemiddleton @basil @ssbarnea @felixfontein