Explicitly turn off autocomplete for API login form #14232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabashian
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
@rooftopcellist thanks for sending this through. Adding autocomplete="off" to each input should work just fine. You could also set it on the form element to hit all the inputs at once. Both approaches should be valid.
|
lgtm! @rooftopcellist can we get this in soonish? |
fosterseth
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Users have pointed out the the username and password should not be autocompleted for the login form. That has been corrected for the UI in this PR, but not for the API for the username. That is what this PR addresses.
I also explicitly set autocomplete to off for the password field even though that appears to be the default.
ISSUE TYPE
COMPONENT NAME