Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Fix for build regression -- #4243 #4253

Merged
merged 2 commits into from
Sep 27, 2024
Merged

[build] Fix for build regression -- #4243 #4253

merged 2 commits into from
Sep 27, 2024

Conversation

kaby76
Copy link
Contributor

@kaby76 kaby76 commented Sep 21, 2024 •
edited
Loading

This is a fix for #4243.

What changed?

  • Trash version 0.23.6 is now used.
  • The Github workflow now installs ts-node, typescript, and tsx because these are used in testing Antlr4ng and TypeScript. This change also fixes problems with split grammars with base classes for TypeScript.
  • Templates for testing have been updated to correct various problems.
    • Replacing find with trglob.
    • Replacing global dotnet tool calls with local.
    • Fixing calls to Antlr4ng and TypeScript programs using npx tsx.
    • For CSharp target, adding code for outputting ambiguous trees with -ambig option, and trparse --ambig.

@kaby76 kaby76 marked this pull request as ready for review September 21, 2024 21:18
@kaby76
Copy link
Contributor Author

kaby76 commented Sep 22, 2024

This PR is required for several outstanding PRs.

This was referenced Sep 25, 2024
Merged
Merged
@teverett
Copy link
Member

@kaby76 thanks

@teverett teverett merged commit df8d7d8 into antlr:master Sep 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaby76 @teverett