-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement podcast functionality #552
base: master
Are you sure you want to change the base?
Conversation
spotify_player/src/state/model.rs
Outdated
match self { | ||
Self::Context(context_id, offset) => Self::Context(context_id.clone(), offset.clone()), | ||
Self::URIs(playable_ids, offset) => Self::URIs( | ||
playable_ids.into_iter().map(|x| x.clone_static()).collect(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of painful places like this throughout the diff where things would be easier if PlayableId
had impl Clone
. Will open a PR against rspotify
to see if that could be added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spotify_player/src/client/request.rs
Outdated
AddTrackToQueue(TrackId<'static>), | ||
AddEpisodeToQueue(EpisodeId<'static>), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to combine these into a AddItemToQueue(PlayableId<'static>)
, but can't do that yet as PlayableId
doesn't impl Debug
or Clone
Anything I can do to help? I would love this feature! |
The biggest outstanding "unknown" is why the playback screen is still blank after starting playback for an episode, so any help diagnosing this would be fantastic. The info in #359 may be helpful here. I was hopeful that updating In general, I'm probably gonna be a bit short on time to be able to push this PR forward this week, but should have more time next week. |
This pull-request is already going to be a doozy to review, so I figured I should open it up for a first look now. Most of the functionality outlined in #457 is implemented here, save one very important part: rendering the currently playing episode in the Player UI. I've been trying to debug why the playing episode does not show up there, but haven't had too much luck yet. I know that |
Lots of errors in CI. I've been testing without enabling features—will update the PR to account for the various features as well |
Work-in-progress implementation of podcasts. Still needs quite a bit of work, but this is a large change so I thought I'd open it up in draft mode in case anyone has any comments along the way.
Playback is working for podcast episodes, as is searching for specific episodes. But the playback is still not being populated—in the process of tracking down why that isn't happening now
Fixes #359
Fixes #457
Checklist (based on #457 (comment))
Screenshots
Search page
Show detail page