add derivable traits to PlayableId and PlayContextId #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
ramsayleung
approved these changes
Aug 22, 2024
SebRollen
added a commit
to SebRollen/rspotify
that referenced
this pull request
Aug 22, 2024
@ramsayleung , thank you for merging ramsayleung#490 After you merged, I noticed that my CHANGELOG entry was under the wrong release. I moved the note to the unreleased portion. Sidenote, but are you able to release these changes as a patch version update instead of waiting for v0.14 to land? Thank you!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR derives the traits
Clone,Debug,PartialEq,Eq,SerializeandHashforPlayContextIdandPlayableId. These two types are enums around other ID types that already derive the same traits.Motivation and Context
I'm currently working on a feature in a downstream crate and there are a few places where we could simplify the code a lot by having these traits be implemented for
PlayableId. I have less need of the same forPlayContextId, but figured I might as well add that to the PR so that all IDs are covered.Dependencies
None
Type of change
Please delete options that are not relevant.
How has this been tested?
Not tested
Is this change properly documented?
Changelog updated