This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
Fix D3 format for some viz types #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: packages/superset-ui-legacy-preset-chart-big-number/src/BigNumber/transformProps.js modified: packages/superset-ui-legacy-preset-chart-nvd3/src/transformProps.js JIRA: SUP-146
|
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
kristw
reviewed
Aug 14, 2019
| @@ -82,7 +82,18 @@ export default function transformProps(chartProps) { | |||
| className = 'negative'; | |||
| } | |||
|
|
|||
| const formatValue = getNumberFormatter(yAxisFormat); | |||
| // SUP-146 | |||
| // SUP-146 | ||
| let metricFormat = yAxisFormat; | ||
| if (!yAxisFormat) { | ||
| for (let x = 0; x < chartProps.datasource.metrics.length; x++) { |
There was a problem hiding this comment.
need to check if datasource exists and metrics exist
| if (!yAxisFormat) { | ||
| for (let x = 0; x < chartProps.datasource.metrics.length; x++) { | ||
| if (chartProps.datasource.metrics[x].metric_name == metric) { | ||
| metricFormat = chartProps.datasource.metrics[x].d3format; |
| let d3YAxis2Format; | ||
| if (chartProps.formData.vizType == "pie") { | ||
| for (let x = 0; x < chartProps.datasource.metrics.length; x++) { | ||
| if (chartProps.datasource.metrics[x].metric_name == chartProps.formData.metric) { |
There was a problem hiding this comment.
Seems like the logic here can be extracted into a function?
3 tasks
|
Picked up the ball on this over here: |
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
…rset#171) * feat: add parseLength function * feat: export * fix: address Kim's comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some viz types don't honor the predefined D3 formats users enter for metrics. This change fixes this for a handful of viz types.