Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create a doap file #10233

Merged
merged 2 commits into from
Apr 25, 2024
Merged

chore: Create a doap file #10233

merged 2 commits into from
Apr 25, 2024

Conversation

tisonkun
Copy link
Member

This closes #10133.

cc @alamb

</description>
<bug-database rdf:resource="https://github.com/apache/datafusion/issues" />
<mailing-list rdf:resource="https://lists.apache.org/[email protected]" />
<download-page rdf:resource="https://github.com/apache/datafusion/releases" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a download page actually, and I suggest we should create one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The official releases will be on the apache download site https://downloads.apache.org/datafusion/ (they are currently on https://downloads.apache.org/arrow/)

However I think the vast majority of datafusion users will get datafusion via crates.io or a direct github link 🤔 I wonder if other types of releases / release page are needed

Any thoughts @andygrove ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good question. We may omit this attribute right now.

The situation is somehow complicated due to the existing ASF policies, which make some assumptions in the old days.

Here is the policy: https://infra.apache.org/release-download-pages.html

You can see a formal Download page has a lot of requirements to follow. But for DataFusion, most users just use cargo add datafusion and never care if such a page exists.

We recently had a discussion on the [email protected] for related topics; while I understand your suggestion here, and we should do what is helpful for our users.

However, Arrow has a release/download page, and I check it meets all the requirements. So if people in DataFusion have time to implement it, we can avoid any further concern.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good -- I filed to track #10236

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @tisonkun 🙏 This looks great

I left a few comments / suggestions, but we could also do them as follow ons

Once we merge this PR I will follow the instructions in https://projects.apache.org/create.html to change the apache site (I think it needs to be a PMC member to do this)

doap.rdf Outdated Show resolved Hide resolved
</description>
<bug-database rdf:resource="https://github.com/apache/datafusion/issues" />
<mailing-list rdf:resource="https://lists.apache.org/[email protected]" />
<download-page rdf:resource="https://github.com/apache/datafusion/releases" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The official releases will be on the apache download site https://downloads.apache.org/datafusion/ (they are currently on https://downloads.apache.org/arrow/)

However I think the vast majority of datafusion users will get datafusion via crates.io or a direct github link 🤔 I wonder if other types of releases / release page are needed

Any thoughts @andygrove ?

doap.rdf Outdated Show resolved Hide resolved
doap.rdf Outdated Show resolved Hide resolved
doap.rdf Show resolved Hide resolved
doap.rdf Outdated Show resolved Hide resolved
@tisonkun
Copy link
Member Author

I think we can merge it as is now. There is no blocker, and we can keep improving if any other good suggestions are made.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @tisonkun

@alamb alamb merged commit bab39f7 into apache:main Apr 25, 2024
23 checks passed
@alamb
Copy link
Contributor

alamb commented Apr 25, 2024

I think we can merge it as is now. There is no blocker, and we can keep improving if any other good suggestions are made.

I agree -- thank you @tisonkun and @andygrove

@alamb
Copy link
Contributor

alamb commented Apr 25, 2024

I added what I think is the entry. See #10133 (comment) -- will keep that updated

ccciudatu pushed a commit to hstack/arrow-datafusion that referenced this pull request Apr 26, 2024
* chore: Create a doap file

Signed-off-by: tison <[email protected]>

* Apply suggestions from code review

Co-authored-by: Andrew Lamb <[email protected]>

---------

Signed-off-by: tison <[email protected]>
Co-authored-by: Andrew Lamb <[email protected]>
@tisonkun tisonkun deleted the doap branch April 26, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a DOAP (description of a project file)
3 participants