Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Create a doap file #10233
chore: Create a doap file #10233
Changes from all commits
a445e2b
8efde04
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a download page actually, and I suggest we should create one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The official releases will be on the apache download site https://downloads.apache.org/datafusion/ (they are currently on https://downloads.apache.org/arrow/)
However I think the vast majority of datafusion users will get datafusion via crates.io or a direct github link 🤔 I wonder if other types of releases / release page are needed
Any thoughts @andygrove ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good question. We may omit this attribute right now.
The situation is somehow complicated due to the existing ASF policies, which make some assumptions in the old days.
Here is the policy: https://infra.apache.org/release-download-pages.html
You can see a formal Download page has a lot of requirements to follow. But for DataFusion, most users just use
cargo add datafusion
and never care if such a page exists.We recently had a discussion on the [email protected] for related topics; while I understand your suggestion here, and we should do what is helpful for our users.
However, Arrow has a release/download page, and I check it meets all the requirements. So if people in DataFusion have time to implement it, we can avoid any further concern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good -- I filed to track #10236