Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhance](nereids) remove first_value and second_value second parameter if the second parameter is false #45264

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[enhance](nereids) remove first_value and second_value second parameter if the second parameter is false #45264

merged 1 commit into from
Dec 11, 2024

Conversation

feiniaofeiafei
Copy link
Contributor

@feiniaofeiafei feiniaofeiafei commented Dec 10, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@feiniaofeiafei
Copy link
Contributor Author

run buildall

@feiniaofeiafei feiniaofeiafei changed the title [enhance](nereids) remove first_value and second_value if the second parameter is false [enhance](nereids) remove first_value and second_value second parameter if the second parameter is false Dec 10, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@feiniaofeiafei
Copy link
Contributor Author

run p0

@zhangstar333 zhangstar333 mentioned this pull request Dec 11, 2024
Merged
16 tasks
@zhangstar333 zhangstar333 merged commit 7a45997 into apache:master Dec 11, 2024
33 of 34 checks passed
BiteTheDDDDt pushed a commit that referenced this pull request Dec 12, 2024
@zhangstar333
[bug](function) fix first/last value return error with ignore null (#…
92015d9 
…44996)

### What problem does this PR solve?

Problem Summary:
needs another prs of FE: #45065
#45264

1. the first value even if have set value, should not return directly,
need check it whether need arg_ignore_null, as maybe it's NULL

2. the last_value if need arg_ignore_null and not set value, should find
in while loop, if find could return directly, not find check iff has any
value before

### Release note

fix first_value/last_value return error with ignore null param is true
github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
@zhangstar333
[bug](function) fix first/last value return error with ignore null (#…
bd0733d 
…44996)

### What problem does this PR solve?

Problem Summary:
needs another prs of FE: #45065
#45264

1. the first value even if have set value, should not return directly,
need check it whether need arg_ignore_null, as maybe it's NULL

2. the last_value if need arg_ignore_null and not set value, should find
in while loop, if find could return directly, not find check iff has any
value before

### Release note

fix first_value/last_value return error with ignore null param is true
github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
@zhangstar333
[bug](function) fix first/last value return error with ignore null (#…
ba844bb 
…44996)

### What problem does this PR solve?

Problem Summary:
needs another prs of FE: #45065
#45264

1. the first value even if have set value, should not return directly,
need check it whether need arg_ignore_null, as maybe it's NULL

2. the last_value if need arg_ignore_null and not set value, should find
in while loop, if find could return directly, not find check iff has any
value before

### Release note

fix first_value/last_value return error with ignore null param is true
github-actions bot pushed a commit that referenced this pull request Dec 16, 2024
@feiniaofeiafei
[enhance](nereids) remove first_value and second_value second paramet…
9e8bbc6 
…er if the second parameter is false (#45264)

### What problem does this PR solve?
Problem Summary: remove first_value and second_value second parameter if the second parameter is false
github-actions bot pushed a commit that referenced this pull request Dec 16, 2024
@feiniaofeiafei
[enhance](nereids) remove first_value and second_value second paramet…
824a245 
…er if the second parameter is false (#45264)

### What problem does this PR solve?
Problem Summary: remove first_value and second_value second parameter if the second parameter is false
This was referenced Dec 16, 2024
Merged
Merged
zhangstar333 pushed a commit that referenced this pull request Dec 16, 2024
@github-actions @feiniaofeiafei
branch-2.1: [enhance](nereids) remove first_value and second_value se…
17f4c1a 
…cond parameter if the second parameter is false #45264 (#45454)

Cherry-picked from #45264

Co-authored-by: feiniaofeiafei <[email protected]>
yiguolei pushed a commit that referenced this pull request Dec 16, 2024
@zhangstar333 @yiguolei
[bug](function) fix first/last value return error with ignore null (#…
6b0a45d 
…44996)

### What problem does this PR solve?

Problem Summary:
needs another prs of FE: #45065
#45264

1. the first value even if have set value, should not return directly,
need check it whether need arg_ignore_null, as maybe it's NULL

2. the last_value if need arg_ignore_null and not set value, should find
in while loop, if find could return directly, not find check iff has any
value before

### Release note

fix first_value/last_value return error with ignore null param is true
zhangstar333 pushed a commit that referenced this pull request Dec 16, 2024
@github-actions @feiniaofeiafei
branch-3.0: [enhance](nereids) remove first_value and second_value se…
13ae167 
…cond parameter if the second parameter is false #45264 (#45453)

Cherry-picked from #45264

Co-authored-by: feiniaofeiafei <[email protected]>
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Dec 16, 2024
@zhangstar333
[bug](function) fix first/last value return error with ignore null (a…
839bcbb 
…pache#44996)

### What problem does this PR solve?

Problem Summary:
needs another prs of FE: apache#45065
apache#45264

1. the first value even if have set value, should not return directly,
need check it whether need arg_ignore_null, as maybe it's NULL

2. the last_value if need arg_ignore_null and not set value, should find
in while loop, if find could return directly, not find check iff has any
value before

### Release note

fix first_value/last_value return error with ignore null param is true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@924060929 924060929 924060929 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@feiniaofeiafei @doris-robot @924060929 @morrySnow @zhangstar333