Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug](function) fix first/last value return error with ignore null #44996

Merged
merged 6 commits into from
Dec 12, 2024
Merged

[bug](function) fix first/last value return error with ignore null #44996

merged 6 commits into from
Dec 12, 2024

Conversation

zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Dec 4, 2024 •
edited
Loading

What problem does this PR solve?

Problem Summary:
needs another prs of FE: #45065 #45264

  1. the first value even if have set value, should not return directly, need check it whether need arg_ignore_null, as maybe it's NULL

  2. the last_value if need arg_ignore_null and not set value, should find in while loop, if find could return directly, not find check iff has any value before

Release note

fix first_value/last_value return error with ignore null param is true

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.47% (10007/26011)
Line Coverage: 29.53% (83921/284219)
Region Coverage: 28.62% (43122/150649)
Branch Coverage: 25.22% (21922/86910)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2249738c79a419c7297961506e1b3ebdc1bd392c_2249738c79a419c7297961506e1b3ebdc1bd392c/report/index.html

@zclllyybb
Copy link
Contributor

maybe this PR need a release note

@zhangstar333
Copy link
Contributor Author

run buildall

@feiniaofeiafei feiniaofeiafei mentioned this pull request Dec 5, 2024
Merged
16 tasks
Gabriel39
Gabriel39 previously approved these changes Dec 6, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 6, 2024
@zhangstar333
Copy link
Contributor Author

need this PR merge first: #45065

morrySnow pushed a commit that referenced this pull request Dec 10, 2024
@feiniaofeiafei
[fix](nereids) not rewrite first_value when first_value ignore nulls (#…
8ad6b28 
…45065)

this pr fix 2 things:
1.when first_value/last_value second parameter is true, which means
ignore nulls, fe should not do some rewrite.
2.adding check that first_value/last_value second parameter must be true
or false.

Related PR: #44996 #27623
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
@feiniaofeiafei
[fix](nereids) not rewrite first_value when first_value ignore nulls (#…
9ff7708 
…45065)

this pr fix 2 things:
1.when first_value/last_value second parameter is true, which means
ignore nulls, fe should not do some rewrite.
2.adding check that first_value/last_value second parameter must be true
or false.

Related PR: #44996 #27623
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
@feiniaofeiafei
[fix](nereids) not rewrite first_value when first_value ignore nulls (#…
8d86b40 
…45065)

this pr fix 2 things:
1.when first_value/last_value second parameter is true, which means
ignore nulls, fe should not do some rewrite.
2.adding check that first_value/last_value second parameter must be true
or false.

Related PR: #44996 #27623
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zhangstar333
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.75% (10104/26074)
Line Coverage: 29.69% (84768/285518)
Region Coverage: 28.74% (43501/151337)
Branch Coverage: 25.30% (22098/87330)
Coverage Report: http://coverage.selectdb-in.cc/coverage/32445f19458ccfbc21359c3c5022b09b32f5e196_32445f19458ccfbc21359c3c5022b09b32f5e196/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 92015d9 into apache:master Dec 12, 2024
26 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
@zhangstar333
[bug](function) fix first/last value return error with ignore null (#…
bd0733d 
…44996)

### What problem does this PR solve?

Problem Summary:
needs another prs of FE: #45065
#45264

1. the first value even if have set value, should not return directly,
need check it whether need arg_ignore_null, as maybe it's NULL

2. the last_value if need arg_ignore_null and not set value, should find
in while loop, if find could return directly, not find check iff has any
value before

### Release note

fix first_value/last_value return error with ignore null param is true
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
@zhangstar333
[bug](function) fix first/last value return error with ignore null (#…
ba844bb 
…44996)

### What problem does this PR solve?

Problem Summary:
needs another prs of FE: #45065
#45264

1. the first value even if have set value, should not return directly,
need check it whether need arg_ignore_null, as maybe it's NULL

2. the last_value if need arg_ignore_null and not set value, should find
in while loop, if find could return directly, not find check iff has any
value before

### Release note

fix first_value/last_value return error with ignore null param is true
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Closed
yiguolei pushed a commit that referenced this pull request Dec 16, 2024
@zhangstar333 @yiguolei
[bug](function) fix first/last value return error with ignore null (#…
6b0a45d 
…44996)

### What problem does this PR solve?

Problem Summary:
needs another prs of FE: #45065
#45264

1. the first value even if have set value, should not return directly,
need check it whether need arg_ignore_null, as maybe it's NULL

2. the last_value if need arg_ignore_null and not set value, should find
in while loop, if find could return directly, not find check iff has any
value before

### Release note

fix first_value/last_value return error with ignore null param is true
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Dec 16, 2024
@zhangstar333
[bug](function) fix first/last value return error with ignore null (a…
839bcbb 
…pache#44996)

### What problem does this PR solve?

Problem Summary:
needs another prs of FE: apache#45065
apache#45264

1. the first value even if have set value, should not return directly,
need check it whether need arg_ignore_null, as maybe it's NULL

2. the last_value if need arg_ignore_null and not set value, should find
in while loop, if find could return directly, not find check iff has any
value before

### Release note

fix first_value/last_value return error with ignore null param is true
@zhangstar333 zhangstar333 mentioned this pull request Dec 16, 2024
Merged
zhangstar333 added a commit that referenced this pull request Dec 16, 2024
@github-actions @zhangstar333
branch-3.0: [bug](function) fix first/last value return error with ig…
8644573 
…nore null #44996 (#45344)

Cherry-picked from #44996

Co-authored-by: zhangstar333 <[email protected]>
zhangstar333 added a commit that referenced this pull request Dec 17, 2024
@zhangstar333
[cherry-pick](branch-21) fix first/last value return error with ignor…
c561bdb 
…e null (#44996) (#45486)

cherry-pick from master #44996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriel39 Gabriel39 Gabriel39 approved these changes

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged p0_w reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zhangstar333 @doris-robot @zclllyybb @BiteTheDDDDt @Gabriel39 @yiguolei