[fix](runtime filter) Fix runtime filter not found #43885

Gabriel39 · 2024-11-13T10:56:48Z

What problem does this PR solve?

Problem Summary:

A runtime filter may have multiple targets and some of those are local-merge RF and others are not.
So for all runtime filters' producers, publish should notify all consumers in global RF mgr which manages local-merge RF and local RF mgr which manages others.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

doris-robot · 2024-11-13T10:56:53Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

Gabriel39 · 2024-11-13T10:57:55Z

run buildall

github-actions

clang-tidy made some suggestions

github-actions · 2024-11-13T11:01:34Z

be/src/runtime/runtime_filter_mgr.cpp

@@ -534,6 +548,10 @@ RuntimeFilterParamsContext* RuntimeFilterParamsContext::create(RuntimeState* sta
    return params;
 }

+RuntimeFilterMgr* RuntimeFilterParamsContext::global_runtime_filter_mgr() {


warning: method 'global_runtime_filter_mgr' can be made const [readability-make-member-function-const]

be/src/runtime/runtime_filter_mgr.h:289:

- RuntimeFilterMgr* global_runtime_filter_mgr(); + RuntimeFilterMgr* global_runtime_filter_mgr() const;

Suggested change

RuntimeFilterMgr* RuntimeFilterParamsContext::global_runtime_filter_mgr() {

RuntimeFilterMgr* RuntimeFilterParamsContext::global_runtime_filter_mgr() const {

Gabriel39 · 2024-11-13T11:06:38Z

run buildall

Gabriel39 · 2024-11-14T02:33:28Z

run buildall

github-actions · 2024-11-14T02:44:48Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-11-14T02:44:50Z

PR approved by anyone and no changes requested.

HappenLee · 2024-11-14T12:14:39Z

be/src/exprs/runtime_filter.cpp

-        DCHECK(!filters.empty());
-        // push down
+    auto send_to_local = [&](std::shared_ptr<RuntimePredicateWrapper> wrapper, bool global) {
+        std::vector<std::shared_ptr<IRuntimeFilter>> filters =


why not add new api get_consume_filters ？ why not find not return error

HappenLee · 2024-11-14T12:28:37Z

be/src/exprs/runtime_filter.cpp

-        RETURN_IF_ERROR(_state->runtime_filter_mgr->get_consume_filters(_filter_id, filters));
-        DCHECK(!filters.empty());
-        // push down
+    auto send_to_local = [&](std::shared_ptr<RuntimePredicateWrapper> wrapper, bool global) {


so here need use global ？ why still name send_to_local ?

HappenLee · 2024-11-14T12:37:45Z

be/src/exprs/runtime_filter.cpp

                _filter_id, &local_merge_filters));
        std::lock_guard l(*local_merge_filters->lock);
        local_merge_filters->merge_size_times--;
        local_merge_filters->local_merged_size += local_filter_size;
+        if (_has_local_target) {


the code is wired, why here use global rf mgr get filter? has_local_target?

github-actions

clang-tidy made some suggestions

github-actions · 2024-11-15T07:09:30Z

be/src/exprs/runtime_filter.cpp

@@ -993,50 +993,54 @@ void IRuntimeFilter::insert_batch(const vectorized::ColumnPtr column, size_t sta
 Status IRuntimeFilter::publish(bool publish_local) {


warning: function 'publish' has cognitive complexity of 82 (threshold 50) [readability-function-cognitive-complexity]

Status IRuntimeFilter::publish(bool publish_local) { ^

Additional context

be/src/exprs/runtime_filter.cpp:995: nesting level increased to 1

auto send_to_remote_targets = [&](IRuntimeFilter* filter) { ^

be/src/exprs/runtime_filter.cpp:998: +2, including nesting penalty of 1, nesting level increased to 2

RETURN_IF_ERROR(_state->global_runtime_filter_mgr()->get_merge_addr(&addr)); ^

be/src/common/status.h:630: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:998: +3, including nesting penalty of 2, nesting level increased to 3

RETURN_IF_ERROR(_state->global_runtime_filter_mgr()->get_merge_addr(&addr)); ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1001: nesting level increased to 1

auto send_to_local_targets = [&](std::shared_ptr<RuntimePredicateWrapper> wrapper, ^

be/src/exprs/runtime_filter.cpp:1013: nesting level increased to 1

auto do_merge = [&]() { ^

be/src/exprs/runtime_filter.cpp:1014: +2, including nesting penalty of 1, nesting level increased to 2

if (!_state->global_runtime_filter_mgr()->get_consume_filters(_filter_id).empty()) { ^

be/src/exprs/runtime_filter.cpp:1016: +3, including nesting penalty of 2, nesting level increased to 3

RETURN_IF_ERROR(_state->global_runtime_filter_mgr()->get_local_merge_producer_filters( ^

be/src/common/status.h:630: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:1016: +4, including nesting penalty of 3, nesting level increased to 4

RETURN_IF_ERROR(_state->global_runtime_filter_mgr()->get_local_merge_producer_filters( ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1019: +3, including nesting penalty of 2, nesting level increased to 3

RETURN_IF_ERROR(local_merge_filters->filters[0]->merge_from(_wrapper.get())); ^

be/src/common/status.h:630: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:1019: +4, including nesting penalty of 3, nesting level increased to 4

RETURN_IF_ERROR(local_merge_filters->filters[0]->merge_from(_wrapper.get())); ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1021: +3, including nesting penalty of 2, nesting level increased to 3

if (local_merge_filters->merge_time == 0) { ^

be/src/exprs/runtime_filter.cpp:1022: +4, including nesting penalty of 3, nesting level increased to 4

if (_has_local_target) { ^

be/src/exprs/runtime_filter.cpp:1023: +5, including nesting penalty of 4, nesting level increased to 5

RETURN_IF_ERROR( ^

be/src/common/status.h:630: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:1023: +6, including nesting penalty of 5, nesting level increased to 6

RETURN_IF_ERROR( ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1025: +1, nesting level increased to 4

} else { ^

be/src/exprs/runtime_filter.cpp:1026: +5, including nesting penalty of 4, nesting level increased to 5

RETURN_IF_ERROR(send_to_remote_targets(local_merge_filters->filters[0].get())); ^

be/src/common/status.h:630: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:1026: +6, including nesting penalty of 5, nesting level increased to 6

RETURN_IF_ERROR(send_to_remote_targets(local_merge_filters->filters[0].get())); ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1033: +1, including nesting penalty of 0, nesting level increased to 1

if (_has_local_target) { ^

be/src/exprs/runtime_filter.cpp:1036: +2, including nesting penalty of 1, nesting level increased to 2

RETURN_IF_ERROR(do_merge()); ^

be/src/common/status.h:630: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:1036: +3, including nesting penalty of 2, nesting level increased to 3

RETURN_IF_ERROR(do_merge()); ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1037: +2, including nesting penalty of 1, nesting level increased to 2

RETURN_IF_ERROR(send_to_local_targets(_wrapper, false)); ^

be/src/common/status.h:630: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:1037: +3, including nesting penalty of 2, nesting level increased to 3

RETURN_IF_ERROR(send_to_local_targets(_wrapper, false)); ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1038: +1, nesting level increased to 1

} else if (!publish_local) { ^

be/src/exprs/runtime_filter.cpp:1039: +2, including nesting penalty of 1, nesting level increased to 2

if (_is_broadcast_join || _state->get_query_ctx()->be_exec_version() < USE_NEW_SERDE) { ^

be/src/exprs/runtime_filter.cpp:1039: +1

if (_is_broadcast_join || _state->get_query_ctx()->be_exec_version() < USE_NEW_SERDE) { ^

be/src/exprs/runtime_filter.cpp:1040: +3, including nesting penalty of 2, nesting level increased to 3

RETURN_IF_ERROR(send_to_remote_targets(this)); ^

be/src/common/status.h:630: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:1040: +4, including nesting penalty of 3, nesting level increased to 4

RETURN_IF_ERROR(send_to_remote_targets(this)); ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1041: +1, nesting level increased to 2

} else { ^

be/src/exprs/runtime_filter.cpp:1042: +3, including nesting penalty of 2, nesting level increased to 3

RETURN_IF_ERROR(do_merge()); ^

be/src/common/status.h:630: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:1042: +4, including nesting penalty of 3, nesting level increased to 4

RETURN_IF_ERROR(do_merge()); ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1044: +1, nesting level increased to 1

} else { ^

Gabriel39 · 2024-11-15T07:12:54Z

run buildall

doris-robot · 2024-11-15T08:28:04Z

TeamCity be ut coverage result:
Function Coverage: 37.99% (9900/26059)
Line Coverage: 29.17% (82685/283475)
Region Coverage: 28.30% (42474/150096)
Branch Coverage: 24.88% (21538/86580)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f0c74091f1c9b64bb6c1b4ed10bfb16a731ae337_f0c74091f1c9b64bb6c1b4ed10bfb16a731ae337/report/index.html

Gabriel39 · 2024-11-15T15:05:12Z

run buildall

Gabriel39 · 2024-11-15T22:39:30Z

run buildall

doris-robot · 2024-11-15T23:49:42Z

TeamCity be ut coverage result:
Function Coverage: 37.98% (9897/26056)
Line Coverage: 29.17% (82699/283489)
Region Coverage: 28.30% (42480/150101)
Branch Coverage: 24.89% (21548/86588)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c32cb5e0194c968ac3503f86b1890876f809a59c_c32cb5e0194c968ac3503f86b1890876f809a59c/report/index.html

HappenLee

LGTM

github-actions · 2024-11-18T02:09:39Z

PR approved by at least one committer and no changes requested.

Gabriel39 · 2024-11-18T02:33:44Z

run buildall

github-actions

clang-tidy made some suggestions

github-actions · 2024-11-18T02:43:41Z

be/src/exprs/runtime_filter.cpp

@@ -993,50 +993,54 @@ void IRuntimeFilter::insert_batch(const vectorized::ColumnPtr column, size_t sta
 Status IRuntimeFilter::publish(RuntimeState* state, bool publish_local) {


warning: function 'publish' has cognitive complexity of 82 (threshold 50) [readability-function-cognitive-complexity]

Status IRuntimeFilter::publish(RuntimeState* state, bool publish_local) { ^

Additional context

be/src/exprs/runtime_filter.cpp:995: nesting level increased to 1

auto send_to_remote_targets = [&](IRuntimeFilter* filter) { ^

be/src/exprs/runtime_filter.cpp:998: +2, including nesting penalty of 1, nesting level increased to 2

RETURN_IF_ERROR(_state->global_runtime_filter_mgr()->get_merge_addr(&addr)); ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:998: +3, including nesting penalty of 2, nesting level increased to 3

RETURN_IF_ERROR(_state->global_runtime_filter_mgr()->get_merge_addr(&addr)); ^

be/src/common/status.h:634: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1001: nesting level increased to 1

auto send_to_local_targets = [&](std::shared_ptr<RuntimePredicateWrapper> wrapper, ^

be/src/exprs/runtime_filter.cpp:1013: nesting level increased to 1

auto do_merge = [&]() { ^

be/src/exprs/runtime_filter.cpp:1014: +2, including nesting penalty of 1, nesting level increased to 2

if (!_state->global_runtime_filter_mgr()->get_consume_filters(_filter_id).empty()) { ^

be/src/exprs/runtime_filter.cpp:1016: +3, including nesting penalty of 2, nesting level increased to 3

RETURN_IF_ERROR(_state->global_runtime_filter_mgr()->get_local_merge_producer_filters( ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:1016: +4, including nesting penalty of 3, nesting level increased to 4

RETURN_IF_ERROR(_state->global_runtime_filter_mgr()->get_local_merge_producer_filters( ^

be/src/common/status.h:634: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1019: +3, including nesting penalty of 2, nesting level increased to 3

RETURN_IF_ERROR(local_merge_filters->filters[0]->merge_from(_wrapper.get())); ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:1019: +4, including nesting penalty of 3, nesting level increased to 4

RETURN_IF_ERROR(local_merge_filters->filters[0]->merge_from(_wrapper.get())); ^

be/src/common/status.h:634: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1021: +3, including nesting penalty of 2, nesting level increased to 3

if (local_merge_filters->merge_time == 0) { ^

be/src/exprs/runtime_filter.cpp:1022: +4, including nesting penalty of 3, nesting level increased to 4

if (_has_local_target) { ^

be/src/exprs/runtime_filter.cpp:1023: +5, including nesting penalty of 4, nesting level increased to 5

RETURN_IF_ERROR( ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:1023: +6, including nesting penalty of 5, nesting level increased to 6

RETURN_IF_ERROR( ^

be/src/common/status.h:634: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1025: +1, nesting level increased to 4

} else { ^

be/src/exprs/runtime_filter.cpp:1026: +5, including nesting penalty of 4, nesting level increased to 5

RETURN_IF_ERROR(send_to_remote_targets(local_merge_filters->filters[0].get())); ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:1026: +6, including nesting penalty of 5, nesting level increased to 6

RETURN_IF_ERROR(send_to_remote_targets(local_merge_filters->filters[0].get())); ^

be/src/common/status.h:634: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1033: +1, including nesting penalty of 0, nesting level increased to 1

if (_has_local_target) { ^

be/src/exprs/runtime_filter.cpp:1036: +2, including nesting penalty of 1, nesting level increased to 2

RETURN_IF_ERROR(do_merge()); ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:1036: +3, including nesting penalty of 2, nesting level increased to 3

RETURN_IF_ERROR(do_merge()); ^

be/src/common/status.h:634: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1037: +2, including nesting penalty of 1, nesting level increased to 2

RETURN_IF_ERROR(send_to_local_targets(_wrapper, false)); ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:1037: +3, including nesting penalty of 2, nesting level increased to 3

RETURN_IF_ERROR(send_to_local_targets(_wrapper, false)); ^

be/src/common/status.h:634: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1038: +1, nesting level increased to 1

} else if (!publish_local) { ^

be/src/exprs/runtime_filter.cpp:1039: +2, including nesting penalty of 1, nesting level increased to 2

if (_is_broadcast_join || _state->get_query_ctx()->be_exec_version() < USE_NEW_SERDE) { ^

be/src/exprs/runtime_filter.cpp:1039: +1

if (_is_broadcast_join || _state->get_query_ctx()->be_exec_version() < USE_NEW_SERDE) { ^

be/src/exprs/runtime_filter.cpp:1040: +3, including nesting penalty of 2, nesting level increased to 3

RETURN_IF_ERROR(send_to_remote_targets(this)); ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:1040: +4, including nesting penalty of 3, nesting level increased to 4

RETURN_IF_ERROR(send_to_remote_targets(this)); ^

be/src/common/status.h:634: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1041: +1, nesting level increased to 2

} else { ^

be/src/exprs/runtime_filter.cpp:1042: +3, including nesting penalty of 2, nesting level increased to 3

RETURN_IF_ERROR(do_merge()); ^

be/src/common/status.h:632: expanded from macro 'RETURN_IF_ERROR'

do { \ ^

be/src/exprs/runtime_filter.cpp:1042: +4, including nesting penalty of 3, nesting level increased to 4

RETURN_IF_ERROR(do_merge()); ^

be/src/common/status.h:634: expanded from macro 'RETURN_IF_ERROR'

if (UNLIKELY(!_status_.ok())) { \ ^

be/src/exprs/runtime_filter.cpp:1044: +1, nesting level increased to 1

} else { ^

HappenLee

LGTM

github-actions · 2024-11-18T03:25:00Z

PR approved by at least one committer and no changes requested.

doris-robot · 2024-11-18T04:26:34Z

TeamCity be ut coverage result:
Function Coverage: 37.97% (9898/26067)
Line Coverage: 29.18% (82768/283626)
Region Coverage: 28.31% (42499/150096)
Branch Coverage: 24.89% (21557/86592)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1d5aa5cc7342cab5384ed2777fea1f6398089b70_1d5aa5cc7342cab5384ed2777fea1f6398089b70/report/index.html

### What problem does this PR solve? Filter size should be set by a global size instead of a local size. This behaviour is introduced by #43885 .

Filter size should be set by a global size instead of a local size. This behaviour is introduced by apache#43885 .

…44718) Filter size should be set by a global size instead of a local size. This behaviour is introduced by #43885 . pick #44708

github-actions bot reviewed Nov 13, 2024

View reviewed changes

Gabriel39 force-pushed the fix_1113 branch from d1223fa to 1a0aa5c Compare November 13, 2024 14:32

BiteTheDDDDt previously approved these changes Nov 14, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 14, 2024

github-actions bot added the reviewed label Nov 14, 2024

dataroaring added the dev/3.0.x label Nov 14, 2024

shuke987 added the p0_b label Nov 14, 2024

HappenLee reviewed Nov 14, 2024

View reviewed changes

Gabriel39 force-pushed the fix_1113 branch from e7d9bd3 to 2393b81 Compare November 15, 2024 04:03

Gabriel39 dismissed BiteTheDDDDt’s stale review via 75d39cd November 15, 2024 07:03

Gabriel39 force-pushed the fix_1113 branch from 2393b81 to 75d39cd Compare November 15, 2024 07:03

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 15, 2024

github-actions bot reviewed Nov 15, 2024

View reviewed changes

Gabriel39 force-pushed the fix_1113 branch from 75d39cd to f0c7409 Compare November 15, 2024 07:11

HappenLee previously approved these changes Nov 18, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 18, 2024

BiteTheDDDDt previously approved these changes Nov 18, 2024

View reviewed changes

Gabriel39 added 3 commits November 18, 2024 10:32

[fix](runtime filter) Fix runtime filter not found

55d3fb7

update

f32ce23

update

1d5aa5c

Gabriel39 dismissed stale reviews from BiteTheDDDDt and HappenLee via 1d5aa5c November 18, 2024 02:32

Gabriel39 force-pushed the fix_1113 branch from c32cb5e to 1d5aa5c Compare November 18, 2024 02:32

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 18, 2024

github-actions bot reviewed Nov 18, 2024

View reviewed changes

HappenLee approved these changes Nov 18, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 18, 2024

dataroaring pushed a commit that referenced this pull request Nov 18, 2024

[branch-3.0](runtime filter) pick #43885 (#44130)

b7a62a0

dataroaring added dev/3.0.3-merged and removed dev/3.0.x labels Nov 18, 2024

BiteTheDDDDt approved these changes Nov 18, 2024

View reviewed changes

Gabriel39 merged commit 103f71f into apache:master Nov 18, 2024
28 of 31 checks passed

Gabriel39 mentioned this pull request Nov 28, 2024

[fix](runtime filter) Sync runtime filter size by a global size #44708

Merged

16 tasks

Gabriel39 mentioned this pull request Nov 28, 2024

[fix](runtime filter) Avoid to use ignored runtime filter (#44708) #44718

Merged

16 tasks

Gabriel39 added a commit that referenced this pull request Nov 28, 2024

[fix](runtime filter) Avoid to use ignored runtime filter (#44708) (#…

5ca36a4

…44718) Filter size should be set by a global size instead of a local size. This behaviour is introduced by #43885 . pick #44708

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[fix](runtime filter) Fix runtime filter not found #43885

[fix](runtime filter) Fix runtime filter not found #43885

Gabriel39 commented Nov 13, 2024 •

edited

Loading

doris-robot commented Nov 13, 2024

Gabriel39 commented Nov 13, 2024

github-actions bot left a comment

github-actions bot Nov 13, 2024

Gabriel39 commented Nov 13, 2024

Gabriel39 commented Nov 14, 2024

github-actions bot commented Nov 14, 2024

github-actions bot commented Nov 14, 2024

HappenLee Nov 14, 2024 •

edited

Loading

HappenLee Nov 14, 2024

HappenLee Nov 14, 2024

github-actions bot left a comment

github-actions bot Nov 15, 2024

Gabriel39 commented Nov 15, 2024

doris-robot commented Nov 15, 2024

Gabriel39 commented Nov 15, 2024

Gabriel39 commented Nov 15, 2024

doris-robot commented Nov 15, 2024

HappenLee left a comment

github-actions bot commented Nov 18, 2024

Gabriel39 commented Nov 18, 2024

github-actions bot left a comment

github-actions bot Nov 18, 2024

HappenLee left a comment

github-actions bot commented Nov 18, 2024

doris-robot commented Nov 18, 2024

	RuntimeFilterMgr* RuntimeFilterParamsContext::global_runtime_filter_mgr() {
	RuntimeFilterMgr* RuntimeFilterParamsContext::global_runtime_filter_mgr() const {

		@@ -993,50 +993,54 @@ void IRuntimeFilter::insert_batch(const vectorized::ColumnPtr column, size_t sta
		Status IRuntimeFilter::publish(bool publish_local) {

		@@ -993,50 +993,54 @@ void IRuntimeFilter::insert_batch(const vectorized::ColumnPtr column, size_t sta
		Status IRuntimeFilter::publish(RuntimeState* state, bool publish_local) {

[fix](runtime filter) Fix runtime filter not found #43885

[fix](runtime filter) Fix runtime filter not found #43885

Conversation

Gabriel39 commented Nov 13, 2024 • edited Loading

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

doris-robot commented Nov 13, 2024

Gabriel39 commented Nov 13, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 13, 2024

Choose a reason for hiding this comment

Gabriel39 commented Nov 13, 2024

Gabriel39 commented Nov 14, 2024

github-actions bot commented Nov 14, 2024

github-actions bot commented Nov 14, 2024

HappenLee Nov 14, 2024 • edited Loading

Choose a reason for hiding this comment

HappenLee Nov 14, 2024

Choose a reason for hiding this comment

HappenLee Nov 14, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 15, 2024

Choose a reason for hiding this comment

Gabriel39 commented Nov 15, 2024

doris-robot commented Nov 15, 2024

Gabriel39 commented Nov 15, 2024

Gabriel39 commented Nov 15, 2024

doris-robot commented Nov 15, 2024

HappenLee left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 18, 2024

Gabriel39 commented Nov 18, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Nov 18, 2024

Choose a reason for hiding this comment

HappenLee left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 18, 2024

doris-robot commented Nov 18, 2024

Gabriel39 commented Nov 13, 2024 •

edited

Loading

HappenLee Nov 14, 2024 •

edited

Loading