Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt](auto-inc) Allow to miss auto-increment column and other value columns in partial update #44528

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ public static Plan normalizePlan(Plan plan, TableIf table, Optional<InsertComman
+ " with sync materialized view.");
}
boolean hasMissingColExceptAutoIncKey = false;
boolean hasMissingAutoIncKey = false;
for (Column col : olapTable.getFullSchema()) {
Optional<String> insertCol = unboundLogicalSink.getColNames().stream()
.filter(c -> c.equalsIgnoreCase(col.getName())).findFirst();
Expand All @@ -313,9 +314,18 @@ public static Plan normalizePlan(Plan plan, TableIf table, Optional<InsertComman
if (!(col.isAutoInc() && col.isKey()) && !insertCol.isPresent() && col.isVisible()) {
hasMissingColExceptAutoIncKey = true;
}
if (col.isAutoInc() && col.isKey() && !insertCol.isPresent()) {
hasMissingAutoIncKey = true;
}
}
if (!hasMissingColExceptAutoIncKey) {
((UnboundTableSink<? extends Plan>) unboundLogicalSink).setPartialUpdate(false);
} else {
if (hasMissingAutoIncKey) {
// becuase of the uniqueness of genetaed value of auto-increment column,
// we convert this load to upsert when is misses auto-increment key column
((UnboundTableSink<? extends Plan>) unboundLogicalSink).setPartialUpdate(false);
}
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,11 @@ doris9
3 888 888 30
4 40 40 40

-- !sql --
test1 15
test2 29
test3 49

-- !sql --
3

Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,46 @@ suite("test_partial_update_auto_inc") {
time 10000
}
order_qt_select_6 "select * from test_primary_key_partial_update_auto_inc2"
sql """ DROP TABLE IF EXISTS test_primary_key_partial_update_auto_inc2 """


sql """ DROP TABLE IF EXISTS test_primary_key_partial_update_auto_inc3 force; """
sql """ create table test_primary_key_partial_update_auto_inc3
(
`id` bigint not null AUTO_INCREMENT,
`project_code` varchar(20) not null,
`period_num` int,
`c2` int
) unique KEY(`id`)
DISTRIBUTED BY HASH(`id`) BUCKETS auto
PROPERTIES (
"replication_allocation" = "tag.location.default: 1",
"enable_unique_key_merge_on_write" = "true"
); """
sql "set enable_unique_key_partial_update=true;"
sql "set enable_insert_strict=false;"
sql "sync;"

sql "insert into test_primary_key_partial_update_auto_inc3(project_code,period_num) values ('test1',15),('test2',29),('test3',49);"
qt_sql "select project_code,period_num from test_primary_key_partial_update_auto_inc3 order by project_code,period_num;"
qt_sql "select count(distinct id) from test_primary_key_partial_update_auto_inc3;"


sql """ DROP TABLE IF EXISTS test_primary_key_partial_update_auto_inc4 """
sql """ CREATE TABLE test_primary_key_partial_update_auto_inc4 (
`k1` BIGINT NOT NULL AUTO_INCREMENT,
`k2` int,
`c1` int,
`c2` int,
`c3` int)
UNIQUE KEY(`k1`,`k2`) DISTRIBUTED BY HASH(`k1`,`k2`) BUCKETS 1
PROPERTIES("replication_num" = "1", "enable_unique_key_merge_on_write" = "true"); """
sql "set enable_unique_key_partial_update=true;"
sql "set enable_insert_strict=false;"
sql "sync;"

test {
sql "insert into test_primary_key_partial_update_auto_inc4(c1,c2) values(1,1),(2,2),(3,3)"
exception "Partial update should include all key columns, missing: k2"
}
}
}
Loading