Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](auto-inc) Allow to miss auto-increment column and other value columns in partial update #44528

Merged
merged 2 commits into from
Nov 29, 2024
Merged

[opt](auto-inc) Allow to miss auto-increment column and other value columns in partial update #44528

merged 2 commits into from
Nov 29, 2024

Conversation

bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Nov 25, 2024 •
edited
Loading

What problem does this PR solve?

Previously, if a partial update misses auto-increment key columns and other value columns, the load will fail with error distributed column not found, column=xxx. Considering the uniqueness of the generated value of auto-increment column, this PR converts the partial update load to upsert in this situation to make it llegal.

Release note

Allow to miss auto-increment key column and other value columns in partial update load

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Contributor Author

bobhan1 commented Nov 25, 2024

run buildall

@zhannngchen
Copy link
Contributor

It's a behavior change, please update the release note

zhannngchen
zhannngchen approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit cd0cd55 into apache:master Nov 29, 2024
35 of 36 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 29, 2024
@bobhan1
[opt](auto-inc) Allow to miss auto-increment column and other value c…
cc8c27f 
…olumns in partial update (#44528)

Previously, if a partial update misses auto-increment key columns and
other value columns, the load will fail with error `distributed column
not found, column=xxx`. Considering the uniqueness of the generated
value of auto-increment column, this PR converts the partial update load
to upsert in this situation to make it llegal.

### Release note

Allow to miss auto-increment key column and other value columns in
partial update load
@github-actions github-actions bot mentioned this pull request Nov 29, 2024
Merged
dataroaring pushed a commit that referenced this pull request Dec 3, 2024
@github-actions @bobhan1
branch-3.0: [opt](auto-inc) Allow to miss auto-increment column and o…
bef24e3 
…ther value columns in partial update #44528 (#44800)

Cherry-picked from #44528

Co-authored-by: bobhan1 <[email protected]>
bobhan1 added a commit to bobhan1/doris that referenced this pull request Dec 6, 2024
@bobhan1
[opt](auto-inc) Allow to miss auto-increment column and other value c…
f8ede26 
…olumns in partial update (apache#44528)

Previously, if a partial update misses auto-increment key columns and
other value columns, the load will fail with error `distributed column
not found, column=xxx`. Considering the uniqueness of the generated
value of auto-increment column, this PR converts the partial update load
to upsert in this situation to make it llegal.

Allow to miss auto-increment key column and other value columns in
partial update load
@bobhan1 bobhan1 mentioned this pull request Dec 6, 2024
Merged
dataroaring pushed a commit that referenced this pull request Dec 6, 2024
@bobhan1
branch-2.1: [opt](auto-inc) Allow to miss auto-increment column and o…
6ddc45b 
…ther value columns in partial update #44528 (#45073)

pick #44528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@zhannngchen zhannngchen zhannngchen approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged kind/behavior-changed reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bobhan1 @doris-robot @zhannngchen @dataroaring