Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](inverted index) Modify Error Handling for File Open Failure #44551

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

zzzxl1993
Copy link
Contributor

@zzzxl1993 zzzxl1993 commented Nov 25, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zzzxl1993
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

// first
trigger_full_compaction_on_tablets.call(tablets)
wait_full_compaction_done.call(tablets)
} finally {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first time trigger full compaction will fail.
Need check rowset count to confirm.

@doris-robot
Copy link

TPC-H: Total hot run time: 39894 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6994db8430799154ce14d7aac1e49f60a0c1575a, data reload: false

------ Round 1 ----------------------------------
q1	17608	8010	7291	7291
q2	2038	169	164	164
q3	10719	1114	1119	1114
q4	10571	781	734	734
q5	7630	2754	2699	2699
q6	240	150	151	150
q7	982	637	610	610
q8	9252	1857	1932	1857
q9	6626	6398	6392	6392
q10	6986	2302	2332	2302
q11	459	263	264	263
q12	442	222	215	215
q13	17768	3036	2991	2991
q14	257	211	209	209
q15	564	529	520	520
q16	683	585	591	585
q17	976	499	597	499
q18	7407	6804	6792	6792
q19	1330	1046	993	993
q20	462	181	175	175
q21	3947	3027	3074	3027
q22	370	325	312	312
Total cold run time: 107317 ms
Total hot run time: 39894 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7231	7206	7223	7206
q2	333	226	233	226
q3	2918	2785	2948	2785
q4	2075	1838	1761	1761
q5	5662	5697	5705	5697
q6	225	145	147	145
q7	2265	1844	1813	1813
q8	3430	3589	3531	3531
q9	8879	8977	8943	8943
q10	3606	3574	3576	3574
q11	607	515	517	515
q12	840	607	631	607
q13	11038	3335	3289	3289
q14	289	264	285	264
q15	575	508	518	508
q16	682	653	654	653
q17	1835	1631	1602	1602
q18	8480	7874	7735	7735
q19	1764	1494	1598	1494
q20	2113	1889	1864	1864
q21	5559	5525	5300	5300
q22	627	600	581	581
Total cold run time: 71033 ms
Total hot run time: 60093 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.33% (9978/26032)
Line Coverage: 29.43% (83515/283776)
Region Coverage: 28.59% (42979/150320)
Branch Coverage: 25.18% (21836/86730)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6994db8430799154ce14d7aac1e49f60a0c1575a_6994db8430799154ce14d7aac1e49f60a0c1575a/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 196847 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6994db8430799154ce14d7aac1e49f60a0c1575a, data reload: false

query1	1241	940	960	940
query2	6240	2132	1981	1981
query3	10813	4037	3961	3961
query4	67274	28633	23713	23713
query5	4972	451	439	439
query6	380	175	170	170
query7	5457	305	304	304
query8	317	227	223	223
query9	8611	2706	2682	2682
query10	444	254	248	248
query11	17258	15232	15925	15232
query12	153	104	104	104
query13	1456	454	428	428
query14	10879	7517	7515	7515
query15	210	186	198	186
query16	7225	482	492	482
query17	1057	577	594	577
query18	1891	319	305	305
query19	212	203	155	155
query20	135	108	109	108
query21	197	98	103	98
query22	4865	4480	4429	4429
query23	34652	34302	34339	34302
query24	5372	2502	2536	2502
query25	477	391	393	391
query26	659	150	153	150
query27	1932	278	273	273
query28	4583	2462	2473	2462
query29	674	419	408	408
query30	230	151	156	151
query31	1028	831	818	818
query32	69	55	51	51
query33	428	288	276	276
query34	942	502	513	502
query35	891	757	734	734
query36	1084	954	985	954
query37	119	73	81	73
query38	4517	4400	4292	4292
query39	1518	1486	1472	1472
query40	205	111	103	103
query41	44	45	43	43
query42	103	125	107	107
query43	518	482	502	482
query44	1201	814	830	814
query45	184	169	163	163
query46	1122	686	709	686
query47	2018	1905	1944	1905
query48	438	341	316	316
query49	725	403	376	376
query50	832	392	398	392
query51	7395	7266	7236	7236
query52	101	84	84	84
query53	253	179	176	176
query54	498	404	393	393
query55	77	73	75	73
query56	243	230	235	230
query57	1299	1195	1145	1145
query58	217	216	210	210
query59	3169	3178	3073	3073
query60	272	240	237	237
query61	106	102	108	102
query62	804	654	680	654
query63	208	181	184	181
query64	1380	658	639	639
query65	3258	3192	3205	3192
query66	708	316	314	314
query67	16088	15524	15683	15524
query68	3748	578	543	543
query69	452	254	258	254
query70	1205	1108	1149	1108
query71	350	244	247	244
query72	6393	4076	4095	4076
query73	744	352	359	352
query74	10185	8961	8961	8961
query75	3404	2708	2631	2631
query76	1843	1098	1108	1098
query77	476	273	264	264
query78	10555	9422	9419	9419
query79	1596	589	581	581
query80	875	430	426	426
query81	542	240	236	236
query82	1269	120	114	114
query83	341	153	150	150
query84	277	65	66	65
query85	890	293	288	288
query86	354	308	273	273
query87	4675	4621	4523	4523
query88	3766	2227	2184	2184
query89	418	290	298	290
query90	2042	190	186	186
query91	136	104	102	102
query92	71	48	57	48
query93	1965	536	535	535
query94	794	304	286	286
query95	348	243	245	243
query96	628	270	284	270
query97	2841	2711	2665	2665
query98	216	197	197	197
query99	1638	1294	1315	1294
Total cold run time: 318965 ms
Total hot run time: 196847 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.17 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6994db8430799154ce14d7aac1e49f60a0c1575a, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.06
query3	0.23	0.08	0.06
query4	1.62	0.10	0.10
query5	0.42	0.43	0.41
query6	1.14	0.66	0.65
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.57	0.53	0.52
query10	0.55	0.57	0.57
query11	0.14	0.11	0.09
query12	0.14	0.11	0.12
query13	0.60	0.61	0.60
query14	2.71	2.88	2.76
query15	0.92	0.82	0.82
query16	0.40	0.40	0.38
query17	1.06	1.03	1.04
query18	0.22	0.21	0.20
query19	1.96	1.75	2.06
query20	0.02	0.01	0.01
query21	15.37	0.61	0.58
query22	2.55	2.05	2.47
query23	16.90	0.97	0.96
query24	3.13	1.26	1.49
query25	0.26	0.11	0.15
query26	0.46	0.13	0.14
query27	0.04	0.04	0.03
query28	10.10	1.10	1.07
query29	12.63	3.20	3.23
query30	0.25	0.07	0.07
query31	2.86	0.39	0.39
query32	3.27	0.44	0.48
query33	3.00	3.01	3.06
query34	17.12	4.46	4.50
query35	4.47	4.50	4.46
query36	0.65	0.49	0.48
query37	0.09	0.06	0.07
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 106.4 s
Total hot run time: 33.17 s

airborne12
airborne12 previously approved these changes Nov 26, 2024
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 26, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 26, 2024
@zzzxl1993
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40092 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 64a3a1e31eec73285cad880bfab0165c2996a5e2, data reload: false

------ Round 1 ----------------------------------
q1	17588	7499	7473	7473
q2	2038	177	167	167
q3	10641	1096	1155	1096
q4	10546	731	725	725
q5	7604	2739	2649	2649
q6	239	149	149	149
q7	992	652	632	632
q8	9255	1864	1905	1864
q9	6545	6349	6363	6349
q10	7016	2286	2302	2286
q11	478	264	254	254
q12	456	223	239	223
q13	17773	3034	3099	3034
q14	248	212	214	212
q15	579	527	516	516
q16	674	602	578	578
q17	995	559	523	523
q18	7180	6721	6669	6669
q19	1341	1081	999	999
q20	472	187	195	187
q21	4132	3198	3285	3198
q22	380	309	314	309
Total cold run time: 107172 ms
Total hot run time: 40092 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7257	7258	7271	7258
q2	324	230	227	227
q3	2961	2847	2906	2847
q4	2099	1874	1900	1874
q5	5649	5679	5682	5679
q6	229	147	146	146
q7	2284	1858	1778	1778
q8	3443	3596	3536	3536
q9	8856	8910	8820	8820
q10	3608	3518	3532	3518
q11	589	514	530	514
q12	850	612	632	612
q13	10269	3260	3242	3242
q14	311	280	291	280
q15	554	520	527	520
q16	676	636	651	636
q17	1895	1657	1631	1631
q18	8342	7764	7741	7741
q19	1687	1597	1442	1442
q20	2116	1876	1930	1876
q21	5635	5395	5464	5395
q22	632	548	588	548
Total cold run time: 70266 ms
Total hot run time: 60120 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.33% (9978/26032)
Line Coverage: 29.42% (83491/283780)
Region Coverage: 28.60% (42986/150307)
Branch Coverage: 25.17% (21828/86728)
Coverage Report: http://coverage.selectdb-in.cc/coverage/64a3a1e31eec73285cad880bfab0165c2996a5e2_64a3a1e31eec73285cad880bfab0165c2996a5e2/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 196538 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 64a3a1e31eec73285cad880bfab0165c2996a5e2, data reload: false

query1	1260	951	947	947
query2	6221	2075	2016	2016
query3	10779	4113	3801	3801
query4	66985	29421	23621	23621
query5	4973	441	442	441
query6	391	172	176	172
query7	5627	291	282	282
query8	298	230	222	222
query9	9266	2737	2724	2724
query10	437	249	238	238
query11	17627	15180	15981	15180
query12	154	107	103	103
query13	1571	433	438	433
query14	10896	7330	7480	7330
query15	216	178	191	178
query16	7069	478	447	447
query17	1126	563	577	563
query18	1818	309	312	309
query19	205	183	166	166
query20	129	124	123	123
query21	209	103	105	103
query22	4751	4478	4342	4342
query23	34923	34427	34230	34230
query24	5480	2495	2536	2495
query25	554	390	389	389
query26	642	145	149	145
query27	1853	281	285	281
query28	4715	2506	2500	2500
query29	729	426	416	416
query30	218	151	154	151
query31	1003	832	829	829
query32	66	56	54	54
query33	401	288	284	284
query34	935	505	518	505
query35	868	758	744	744
query36	1081	992	977	977
query37	124	76	83	76
query38	4479	4558	4427	4427
query39	1566	1479	1474	1474
query40	207	95	108	95
query41	46	45	42	42
query42	107	97	95	95
query43	529	494	505	494
query44	1197	834	848	834
query45	198	175	174	174
query46	1153	713	704	704
query47	2009	1925	1918	1918
query48	422	335	330	330
query49	743	403	420	403
query50	859	396	409	396
query51	7425	7251	7269	7251
query52	93	87	88	87
query53	251	179	179	179
query54	503	398	399	398
query55	81	76	75	75
query56	260	238	243	238
query57	1267	1194	1156	1156
query58	217	210	217	210
query59	3198	2920	2861	2861
query60	259	280	248	248
query61	108	105	105	105
query62	796	670	684	670
query63	209	187	203	187
query64	1369	655	630	630
query65	3315	3237	3220	3220
query66	694	301	308	301
query67	15814	15604	15887	15604
query68	3999	570	550	550
query69	452	258	252	252
query70	1187	1166	1035	1035
query71	351	247	258	247
query72	6460	4063	3988	3988
query73	761	360	357	357
query74	10119	9068	9004	9004
query75	3391	2664	2815	2664
query76	1715	1050	1088	1050
query77	466	274	279	274
query78	10696	9436	9411	9411
query79	1667	606	607	606
query80	875	422	434	422
query81	509	234	226	226
query82	1230	121	115	115
query83	274	146	149	146
query84	288	70	76	70
query85	902	301	294	294
query86	343	287	296	287
query87	4761	4540	4674	4540
query88	3672	2239	2203	2203
query89	419	296	295	295
query90	2010	191	184	184
query91	134	105	102	102
query92	68	48	51	48
query93	1898	547	541	541
query94	823	279	281	279
query95	347	246	254	246
query96	616	277	285	277
query97	2893	2724	2709	2709
query98	215	199	196	196
query99	2088	1323	1297	1297
Total cold run time: 320603 ms
Total hot run time: 196538 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.76 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 64a3a1e31eec73285cad880bfab0165c2996a5e2, data reload: false

query1	0.03	0.02	0.04
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.61	0.10	0.11
query5	0.42	0.42	0.41
query6	1.13	0.67	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.52	0.50
query10	0.56	0.56	0.56
query11	0.15	0.11	0.12
query12	0.14	0.11	0.11
query13	0.62	0.61	0.59
query14	2.77	2.70	2.86
query15	0.92	0.83	0.83
query16	0.38	0.39	0.37
query17	1.03	1.06	1.05
query18	0.23	0.21	0.21
query19	1.89	1.90	2.04
query20	0.01	0.01	0.02
query21	15.36	0.59	0.60
query22	2.82	1.91	1.61
query23	17.27	0.89	0.85
query24	2.92	1.54	1.33
query25	0.30	0.14	0.07
query26	0.58	0.14	0.13
query27	0.06	0.04	0.05
query28	10.54	1.11	1.09
query29	12.57	3.19	3.21
query30	0.25	0.06	0.06
query31	2.86	0.38	0.38
query32	3.26	0.47	0.48
query33	3.08	3.02	3.01
query34	16.93	4.41	4.43
query35	4.59	4.45	4.48
query36	0.66	0.49	0.49
query37	0.10	0.06	0.07
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.16	0.12	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.4 s
Total hot run time: 32.76 s

qidaye
qidaye previously approved these changes Nov 26, 2024
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 26, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@zzzxl1993
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40484 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 64a3a1e31eec73285cad880bfab0165c2996a5e2, data reload: false

------ Round 1 ----------------------------------
q1	17646	7640	7340	7340
q2	2048	177	178	177
q3	10627	1182	1200	1182
q4	10267	767	814	767
q5	7635	2747	2755	2747
q6	241	148	145	145
q7	1011	622	608	608
q8	9263	1869	1955	1869
q9	6528	6457	6497	6457
q10	7025	2294	2325	2294
q11	459	267	259	259
q12	415	217	214	214
q13	17759	3036	3002	3002
q14	239	208	213	208
q15	582	529	524	524
q16	652	598	596	596
q17	996	585	617	585
q18	7496	6718	6721	6718
q19	1332	1048	1058	1048
q20	491	192	185	185
q21	4088	3267	3248	3248
q22	393	315	311	311
Total cold run time: 107193 ms
Total hot run time: 40484 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7257	7238	7252	7238
q2	329	226	233	226
q3	2962	2973	3138	2973
q4	2094	1831	1820	1820
q5	5616	5686	5631	5631
q6	221	138	138	138
q7	2175	1805	1903	1805
q8	3423	3553	3542	3542
q9	8865	8853	8857	8853
q10	3604	3566	3562	3562
q11	600	508	512	508
q12	833	644	603	603
q13	12165	3194	3244	3194
q14	299	271	267	267
q15	596	501	499	499
q16	691	632	627	627
q17	1815	1576	1567	1567
q18	7883	7410	7282	7282
q19	1681	1395	1442	1395
q20	2063	1799	1803	1799
q21	5387	5192	5196	5192
q22	632	559	586	559
Total cold run time: 71191 ms
Total hot run time: 59280 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.35% (9976/26013)
Line Coverage: 29.45% (83506/283517)
Region Coverage: 28.59% (42969/150297)
Branch Coverage: 25.19% (21825/86630)
Coverage Report: http://coverage.selectdb-in.cc/coverage/64a3a1e31eec73285cad880bfab0165c2996a5e2_64a3a1e31eec73285cad880bfab0165c2996a5e2/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 191274 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 64a3a1e31eec73285cad880bfab0165c2996a5e2, data reload: false

query1	968	373	370	370
query2	6508	2101	2142	2101
query3	6703	211	217	211
query4	34233	23730	23546	23546
query5	4292	460	455	455
query6	274	181	176	176
query7	4627	298	299	298
query8	299	228	232	228
query9	9805	2640	2640	2640
query10	493	262	260	260
query11	18067	15183	15136	15136
query12	148	103	103	103
query13	1654	435	439	435
query14	9942	7453	7410	7410
query15	318	182	186	182
query16	8207	461	456	456
query17	1819	586	563	563
query18	2145	301	298	298
query19	398	145	141	141
query20	120	113	119	113
query21	207	99	114	99
query22	4669	4259	4222	4222
query23	34775	33927	34789	33927
query24	11474	2456	2412	2412
query25	569	383	389	383
query26	1275	146	154	146
query27	2775	277	281	277
query28	8067	2417	2394	2394
query29	686	398	398	398
query30	305	150	156	150
query31	1064	815	801	801
query32	89	55	60	55
query33	770	294	280	280
query34	963	495	521	495
query35	867	713	710	710
query36	1134	972	970	970
query37	210	79	70	70
query38	4487	4223	4229	4223
query39	1492	1418	1444	1418
query40	280	98	97	97
query41	48	47	45	45
query42	113	97	99	97
query43	553	493	499	493
query44	1317	801	808	801
query45	185	161	168	161
query46	1149	691	702	691
query47	1913	1839	1878	1839
query48	395	311	317	311
query49	1282	374	387	374
query50	801	389	387	387
query51	7289	7177	7027	7027
query52	101	91	89	89
query53	251	186	181	181
query54	1166	396	404	396
query55	79	77	81	77
query56	260	239	227	227
query57	1293	1184	1130	1130
query58	225	212	228	212
query59	3287	3106	3121	3106
query60	269	245	242	242
query61	115	109	103	103
query62	890	695	671	671
query63	213	190	185	185
query64	4930	651	605	605
query65	3309	3209	3214	3209
query66	1307	315	308	308
query67	16087	15673	15630	15630
query68	5378	532	546	532
query69	420	250	252	250
query70	1210	1163	1133	1133
query71	348	256	255	255
query72	6084	3992	4013	3992
query73	762	357	357	357
query74	10382	8984	9051	8984
query75	3444	2773	2670	2670
query76	3318	1119	1128	1119
query77	533	271	311	271
query78	10568	9428	9398	9398
query79	1666	594	596	594
query80	1102	436	441	436
query81	550	229	225	225
query82	968	117	117	117
query83	242	150	153	150
query84	247	73	71	71
query85	1423	292	287	287
query86	425	312	291	291
query87	4737	4681	4600	4600
query88	3417	2183	2150	2150
query89	402	295	301	295
query90	2120	187	187	187
query91	138	104	103	103
query92	67	52	51	51
query93	1256	529	538	529
query94	1136	295	284	284
query95	359	251	251	251
query96	622	275	281	275
query97	2862	2743	2673	2673
query98	220	200	205	200
query99	1666	1298	1320	1298
Total cold run time: 304077 ms
Total hot run time: 191274 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 34 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 64a3a1e31eec73285cad880bfab0165c2996a5e2, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.04	0.04
query3	0.24	0.07	0.07
query4	1.61	0.10	0.11
query5	0.43	0.40	0.40
query6	1.15	0.67	0.68
query7	0.02	0.02	0.01
query8	0.04	0.04	0.03
query9	0.59	0.53	0.49
query10	0.56	0.55	0.56
query11	0.14	0.10	0.10
query12	0.13	0.11	0.11
query13	0.62	0.60	0.60
query14	2.82	2.85	2.72
query15	0.90	0.83	0.83
query16	0.39	0.38	0.40
query17	0.97	1.06	1.04
query18	0.22	0.21	0.20
query19	1.94	1.85	1.97
query20	0.01	0.01	0.02
query21	15.38	0.59	0.58
query22	2.58	2.61	2.79
query23	16.99	1.04	0.71
query24	3.78	1.48	1.68
query25	0.25	0.17	0.18
query26	0.51	0.15	0.14
query27	0.05	0.04	0.05
query28	9.39	1.10	1.08
query29	12.54	3.28	3.25
query30	0.25	0.07	0.06
query31	2.85	0.39	0.38
query32	3.28	0.46	0.47
query33	2.98	3.06	3.06
query34	16.85	4.48	4.47
query35	4.46	4.57	4.48
query36	0.66	0.50	0.49
query37	0.09	0.07	0.07
query38	0.05	0.03	0.04
query39	0.03	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.18 s
Total hot run time: 34 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.35% (9976/26013)
Line Coverage: 29.45% (83483/283517)
Region Coverage: 28.59% (42969/150297)
Branch Coverage: 25.19% (21822/86630)
Coverage Report: http://coverage.selectdb-in.cc/coverage/64a3a1e31eec73285cad880bfab0165c2996a5e2_64a3a1e31eec73285cad880bfab0165c2996a5e2/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 191479 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bd2894ded4b38c9447292c8bee1c5270d1bb5e07, data reload: false

query1	982	380	386	380
query2	6533	2204	2157	2157
query3	6704	214	213	213
query4	33925	23445	23611	23445
query5	4335	465	462	462
query6	277	192	173	173
query7	4637	303	299	299
query8	300	234	237	234
query9	9604	2646	2640	2640
query10	480	257	255	255
query11	18274	15390	15194	15194
query12	159	107	117	107
query13	1673	406	428	406
query14	10363	7601	7506	7506
query15	300	191	184	184
query16	8207	426	459	426
query17	1817	581	560	560
query18	2144	297	286	286
query19	353	144	156	144
query20	115	117	141	117
query21	209	103	100	100
query22	4548	4373	4253	4253
query23	34840	34228	34147	34147
query24	11477	2394	2397	2394
query25	661	386	422	386
query26	1757	147	156	147
query27	2858	284	271	271
query28	8167	2385	2404	2385
query29	1026	396	411	396
query30	304	149	148	148
query31	1039	809	821	809
query32	102	61	58	58
query33	772	293	278	278
query34	1020	529	513	513
query35	853	713	713	713
query36	1118	944	959	944
query37	275	79	77	77
query38	4397	4319	4252	4252
query39	1490	1424	1423	1423
query40	280	103	99	99
query41	47	43	42	42
query42	105	96	95	95
query43	557	505	499	499
query44	1277	796	808	796
query45	184	161	163	161
query46	1123	667	671	667
query47	1934	1800	1841	1800
query48	419	303	318	303
query49	1284	384	377	377
query50	820	380	388	380
query51	7371	7102	7179	7102
query52	103	91	88	88
query53	261	179	178	178
query54	1248	402	403	402
query55	78	78	82	78
query56	275	245	240	240
query57	1303	1192	1170	1170
query58	231	212	221	212
query59	3274	2988	3238	2988
query60	268	244	276	244
query61	110	106	106	106
query62	900	679	689	679
query63	217	186	180	180
query64	5069	659	673	659
query65	3305	3215	3239	3215
query66	1430	336	310	310
query67	15807	15632	15493	15493
query68	5078	537	542	537
query69	424	252	250	250
query70	1243	1168	1180	1168
query71	349	252	255	252
query72	6321	4057	4000	4000
query73	771	357	365	357
query74	10486	9073	9106	9073
query75	3530	2657	2698	2657
query76	2863	1020	1147	1020
query77	505	267	283	267
query78	10404	9443	9445	9443
query79	1699	598	603	598
query80	1159	439	444	439
query81	527	231	242	231
query82	939	121	115	115
query83	247	158	148	148
query84	245	79	69	69
query85	1388	298	307	298
query86	431	307	287	287
query87	4729	4546	4713	4546
query88	3471	2185	2142	2142
query89	401	291	295	291
query90	2107	185	185	185
query91	139	103	108	103
query92	64	57	103	57
query93	1442	542	539	539
query94	1141	295	300	295
query95	359	251	248	248
query96	614	273	271	271
query97	2871	2667	2693	2667
query98	216	198	201	198
query99	1538	1296	1283	1283
Total cold run time: 305076 ms
Total hot run time: 191479 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.96 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bd2894ded4b38c9447292c8bee1c5270d1bb5e07, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.03
query3	0.24	0.08	0.07
query4	1.62	0.11	0.11
query5	0.43	0.42	0.42
query6	1.15	0.68	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.04
query9	0.59	0.53	0.51
query10	0.57	0.55	0.55
query11	0.13	0.11	0.11
query12	0.13	0.11	0.12
query13	0.61	0.60	0.61
query14	2.74	2.83	2.75
query15	0.91	0.84	0.84
query16	0.39	0.38	0.38
query17	1.01	1.03	1.03
query18	0.23	0.20	0.21
query19	1.90	1.86	2.08
query20	0.01	0.01	0.01
query21	15.35	0.60	0.57
query22	2.35	2.11	2.64
query23	17.09	0.86	0.79
query24	2.86	1.80	0.95
query25	0.22	0.16	0.27
query26	0.40	0.14	0.13
query27	0.05	0.05	0.04
query28	10.32	1.11	1.09
query29	12.58	3.28	3.24
query30	0.25	0.06	0.06
query31	2.87	0.39	0.38
query32	3.28	0.47	0.48
query33	3.02	3.02	3.04
query34	17.10	4.45	4.41
query35	4.48	4.44	4.48
query36	0.67	0.48	0.48
query37	0.10	0.07	0.07
query38	0.05	0.03	0.04
query39	0.03	0.03	0.02
query40	0.16	0.13	0.12
query41	0.07	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.2 s
Total hot run time: 32.96 s

@zzzxl1993
Copy link
Contributor Author

run buildall

1 similar comment
@zzzxl1993
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 27, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 39963 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5cf745524c391e648bbea20b47b37193ce90f897, data reload: false

------ Round 1 ----------------------------------
q1	17594	7669	7373	7373
q2	2046	173	170	170
q3	10793	1102	1181	1102
q4	10505	790	745	745
q5	7616	2730	2726	2726
q6	235	159	151	151
q7	973	630	600	600
q8	9233	1889	1939	1889
q9	6610	6416	6382	6382
q10	7059	2280	2371	2280
q11	466	281	265	265
q12	408	221	219	219
q13	17776	3063	3019	3019
q14	241	208	211	208
q15	573	535	513	513
q16	673	581	567	567
q17	967	502	571	502
q18	7238	6705	6628	6628
q19	1348	985	1028	985
q20	457	183	188	183
q21	4050	3145	3192	3145
q22	382	319	311	311
Total cold run time: 107243 ms
Total hot run time: 39963 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7285	7249	7230	7230
q2	324	230	230	230
q3	2893	2814	2968	2814
q4	2058	1823	1844	1823
q5	5703	5672	5635	5635
q6	222	141	144	141
q7	2238	1852	1797	1797
q8	3408	3530	3485	3485
q9	8873	8919	8917	8917
q10	3622	3556	3585	3556
q11	624	505	555	505
q12	820	615	666	615
q13	10532	3256	3208	3208
q14	311	273	279	273
q15	569	531	535	531
q16	687	650	642	642
q17	1875	1623	1593	1593
q18	8359	7725	7629	7629
q19	1688	1471	1631	1471
q20	2123	1940	1871	1871
q21	5620	5263	5464	5263
q22	681	594	593	593
Total cold run time: 70515 ms
Total hot run time: 59822 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.35% (9977/26016)
Line Coverage: 29.45% (83533/283620)
Region Coverage: 28.59% (42989/150348)
Branch Coverage: 25.20% (21839/86666)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5cf745524c391e648bbea20b47b37193ce90f897_5cf745524c391e648bbea20b47b37193ce90f897/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 196165 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5cf745524c391e648bbea20b47b37193ce90f897, data reload: false

query1	1257	952	932	932
query2	6234	2133	2069	2069
query3	10864	4172	3949	3949
query4	67860	27982	23499	23499
query5	4933	457	442	442
query6	417	207	180	180
query7	5528	298	291	291
query8	309	245	217	217
query9	8685	2727	2690	2690
query10	436	245	242	242
query11	16974	15276	15835	15276
query12	167	106	106	106
query13	1472	452	444	444
query14	10470	6752	7556	6752
query15	215	191	191	191
query16	7130	486	446	446
query17	1036	569	586	569
query18	2039	312	298	298
query19	198	154	155	154
query20	161	113	111	111
query21	206	102	101	101
query22	4608	4468	4568	4468
query23	34827	34222	34329	34222
query24	5490	2543	2472	2472
query25	487	381	396	381
query26	661	145	153	145
query27	1939	286	296	286
query28	4336	2506	2508	2506
query29	673	428	443	428
query30	218	146	144	144
query31	962	831	885	831
query32	67	52	58	52
query33	406	284	293	284
query34	912	511	526	511
query35	829	755	727	727
query36	1069	969	945	945
query37	131	81	74	74
query38	4564	4385	4327	4327
query39	1538	1491	1460	1460
query40	205	99	100	99
query41	48	46	49	46
query42	109	101	101	101
query43	553	503	498	498
query44	1154	825	817	817
query45	198	204	170	170
query46	1158	737	728	728
query47	2046	1916	1932	1916
query48	414	328	326	326
query49	725	383	401	383
query50	842	410	403	403
query51	7293	7186	7120	7120
query52	102	93	90	90
query53	246	175	185	175
query54	508	404	389	389
query55	81	75	80	75
query56	247	234	241	234
query57	1262	1180	1178	1178
query58	233	221	226	221
query59	3304	3029	3057	3029
query60	275	250	250	250
query61	135	129	130	129
query62	806	673	710	673
query63	213	193	196	193
query64	1467	691	615	615
query65	3286	3197	3208	3197
query66	699	296	314	296
query67	16074	15667	15511	15511
query68	4160	566	555	555
query69	438	251	258	251
query70	1123	1087	1068	1068
query71	344	246	244	244
query72	6364	4011	4092	4011
query73	757	362	366	362
query74	10229	9007	8995	8995
query75	3387	2661	2720	2661
query76	1871	1085	1034	1034
query77	482	304	300	300
query78	10645	9544	9747	9544
query79	1898	598	617	598
query80	1390	430	437	430
query81	522	235	220	220
query82	1312	116	121	116
query83	175	145	151	145
query84	286	75	68	68
query85	991	306	302	302
query86	393	304	277	277
query87	4734	4558	4646	4558
query88	3505	2251	2202	2202
query89	422	296	341	296
query90	1988	191	183	183
query91	135	104	101	101
query92	59	48	56	48
query93	2388	536	539	536
query94	821	281	298	281
query95	344	249	251	249
query96	636	289	281	281
query97	2889	2703	2671	2671
query98	213	201	193	193
query99	1773	1301	1304	1301
Total cold run time: 320665 ms
Total hot run time: 196165 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.59 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5cf745524c391e648bbea20b47b37193ce90f897, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.24	0.08	0.07
query4	1.61	0.11	0.10
query5	0.42	0.42	0.41
query6	1.17	0.66	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.57	0.50	0.50
query10	0.56	0.57	0.54
query11	0.15	0.10	0.10
query12	0.15	0.12	0.11
query13	0.62	0.60	0.60
query14	2.75	2.82	2.75
query15	0.91	0.82	0.83
query16	0.38	0.39	0.38
query17	1.01	1.00	1.07
query18	0.22	0.20	0.22
query19	1.86	1.89	2.01
query20	0.01	0.02	0.02
query21	15.38	0.59	0.57
query22	2.36	2.69	2.16
query23	16.92	0.84	0.91
query24	2.98	1.81	1.53
query25	0.21	0.04	0.13
query26	0.62	0.14	0.13
query27	0.04	0.04	0.04
query28	9.84	1.10	1.07
query29	12.60	3.21	3.20
query30	0.25	0.07	0.06
query31	2.86	0.38	0.37
query32	3.28	0.47	0.48
query33	2.96	3.06	3.09
query34	16.98	4.60	4.53
query35	4.62	4.52	4.48
query36	0.65	0.49	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.15	0.13
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.78 s
Total hot run time: 33.59 s

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 27, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qidaye qidaye merged commit f6ff621 into apache:master Nov 27, 2024
25 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 27, 2024
…4551)

Problem Summary:

Modify Error Handling for File Open Failure
dataroaring pushed a commit that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants