Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Nereids) fix fold constant of string_index in fe #44740

Closed
wants to merge 1 commit into from

Conversation

LiBinfeng-01
Copy link
Collaborator

@LiBinfeng-01 LiBinfeng-01 commented Nov 28, 2024

What problem does this PR solve?

Issue Number: close #44666

Related PR: #xxx

Problem Summary:

select string_index('哈哈哈AAA','A', 1); would return whole string when 1 is larger equal than string.splitpart
So we should change splitpart limit to -1 to enable empty character in splitpart list

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@morrySnow morrySnow added usercase Important user case type label dev/2.1.x dev/3.0.x p0_w labels Nov 28, 2024
@LiBinfeng-01
Copy link
Collaborator Author

run external

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p0_w usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] upgrading from 2.1.2->2.1.7 causes query result error
4 participants