Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Nereids) fix fold constant of string_index in fe #44740

Closed
wants to merge 1 commit into from
+23 −1
Closed

[fix](Nereids) fix fold constant of string_index in fe #44740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ava/org/apache/doris/nereids/trees/expressions/functions/executable/StringArithmetic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ public static Expression splitPart(StringLikeLiteral first, StringLikeLiteral ch
*/
@ExecFunction(name = "substring_index")
public static Expression substringIndex(StringLikeLiteral first, StringLikeLiteral chr, IntegerLiteral number) {
String[] parts = first.getValue().split(chr.getValue());
String[] parts = first.getValue().split(chr.getValue(), -1);
if (Math.abs(number.getValue()) >= parts.length) {
return first;
}
Expand Down
22 changes: 22 additions & 0 deletions ...on-test/suites/nereids_p0/expression/fold_constant/fold_constant_string_arithmatic.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,5 +774,27 @@ suite("fold_constant_string_arithmatic") {
testFoldConst("select append_trailing_char_if_absent('hello', ' ')")
// Expected Output: 'hello '

testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AAA','A', -5)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AAA','A', -4)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AAA','A', -3)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AAA','A', -2)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AAA','A', -1)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AAA','A', 0)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AAA','A', 1)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AAA','A', 2)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AAA','A', 3)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AAA','A', 4)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AAA','A', 5)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AA+','A', -4)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AA+','A', -3)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AA+','A', -2)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AA+','A', -1)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AA+','A', 0)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AA+','A', 1)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AA+','A', 2)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AA+','A', 3)")
testFoldConst("SELECT SUBSTRING_INDEX('哈哈哈AA+','A', 4)")



}