Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Opt](SegmentIterator) clear and release iterators memory footprint in advance when EOF #44768

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[Opt](SegmentIterator) clear and release iterators memory footprint in advance when EOF #44768

merged 1 commit into from
Dec 2, 2024

Conversation

eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Nov 29, 2024 •
edited
Loading

Otherwise the memory will hold until BetaRowsetReader released

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon
Copy link
Member Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.33% (9977/26031)
Line Coverage: 29.41% (83535/284052)
Region Coverage: 28.54% (43006/150682)
Branch Coverage: 25.16% (21839/86814)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d5e22689f6745b22b9f05750f8a71944815905fb_d5e22689f6745b22b9f05750f8a71944815905fb/report/index.html

airborne12
airborne12 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

PR approved by anyone and no changes requested.

qidaye
qidaye approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon merged commit 7d7f7fe into apache:master Dec 2, 2024
29 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 2, 2024
@eldenmoon
[Opt](SegmentIterator) clear and release iterators memory footprint i…
e598e98 
…n advance when EOF (#44768)

Otherwise the memory will hold until BetaRowsetReader released
@github-actions github-actions bot mentioned this pull request Dec 2, 2024
Merged
eldenmoon added a commit that referenced this pull request Dec 2, 2024
@github-actions @eldenmoon
branch-3.0: [Opt](SegmentIterator) clear and release iterators memory…
9affc10 
… footprint in advance when EOF #44768 (#44839)

Cherry-picked from #44768

Co-authored-by: lihangyu <[email protected]>
@eldenmoon eldenmoon deleted the pre_clear_iter branch December 5, 2024 03:12
@eldenmoon eldenmoon restored the pre_clear_iter branch December 6, 2024 07:17
@eldenmoon eldenmoon deleted the pre_clear_iter branch December 6, 2024 07:17
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Dec 20, 2024
@eldenmoon
[Opt](SegmentIterator) clear and release iterators memory footprint i…
21a41e1 
…n advance when EOF (apache#44768)

Otherwise the memory will hold until BetaRowsetReader released
@eldenmoon eldenmoon mentioned this pull request Dec 20, 2024
Merged
yiguolei pushed a commit that referenced this pull request Dec 20, 2024
@eldenmoon
[Opt](SegmentIterator) clear and release iterators memory footprint i…
06efd5b 
…n advance when EOF (#44768) (#45734)

(#44768)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qidaye qidaye qidaye approved these changes

@airborne12 airborne12 airborne12 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eldenmoon @doris-robot @airborne12 @qidaye @yiguolei