Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat](binlog) Add Support recover binlog #44818

Merged
merged 3 commits into from
Dec 11, 2024
Merged

[feat](binlog) Add Support recover binlog #44818

merged 3 commits into from
Dec 11, 2024

Conversation

Vallishp
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
Support recover in ccr-syncer.

Release note

None

Check List (For Author)

  • Test

    • Regression test // ccr-syncer PR
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Vallishp Vallishp marked this pull request as draft November 30, 2024 13:29
@Vallishp Vallishp marked this pull request as ready for review December 1, 2024 15:14
@Vallishp
Copy link
Contributor Author

Vallishp commented Dec 1, 2024

run buildall

@Vallishp Vallishp mentioned this pull request Dec 2, 2024
Merged
@Vallishp
Copy link
Contributor Author

Vallishp commented Dec 2, 2024

run buildall

dataroaring
dataroaring previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

PR approved by anyone and no changes requested.

w41ter
w41ter requested changes Dec 9, 2024
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/binlog/BinlogManager.java
@@ -446,6 +447,17 @@ public void addDropRollup(DropInfo info, long commitSeq) {
addBinlog(dbId, tableIds, commitSeq, timestamp, type, data, false, info);
}

public void addRecoverTableRecord(RecoverInfo info, long commitSeq) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RecoverInfo comes from the old version of Doris, which does not contain TableName and PartitionName, and should be filtered here. Otherwise, it might cause the ccr syncer to stop synching.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you. have update it.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 9, 2024
@Vallishp
Copy link
Contributor Author

Vallishp commented Dec 9, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Vallishp
Copy link
Contributor Author

Vallishp commented Dec 9, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Vallishp
Copy link
Contributor Author

Vallishp commented Dec 9, 2024

run p0

dataroaring
dataroaring approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@w41ter w41ter merged commit 502542d into apache:master Dec 11, 2024
25 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
@Vallishp
[feat](binlog) Add Support recover binlog (#44818)
3d68d81
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
@Vallishp
[feat](binlog) Add Support recover binlog (#44818)
ca089b0
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Merged
dataroaring pushed a commit that referenced this pull request Dec 12, 2024
@github-actions @Vallishp
branch-3.0: [feat](binlog) Add Support recover binlog #44818 (#45293)
46e4400 
Cherry-picked from #44818

Co-authored-by: Vallish Pai <[email protected]>
yiguolei pushed a commit that referenced this pull request Dec 18, 2024
@github-actions @Vallishp
branch-2.1: [feat](binlog) Add Support recover binlog #44818 (#45294)
ab427f6 
Cherry-picked from #44818

Co-authored-by: Vallish Pai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@w41ter w41ter w41ter approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vallishp @doris-robot @w41ter @dataroaring @yiguolei