Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] (inverted index) fix index file in gc binlogs #44994

Merged
merged 4 commits into from
Dec 16, 2024
Merged

[fix] (inverted index) fix index file in gc binlogs #44994

merged 4 commits into from
Dec 16, 2024

Conversation

csun5285
Copy link
Contributor

@csun5285 csun5285 commented Dec 4, 2024 •
edited
Loading

What problem does this PR solve?

Problem Summary:

  1. remove duplicate function get_segment_index_filepath
  2. fix gc binlogs

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@csun5285
Copy link
Contributor Author

csun5285 commented Dec 4, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.48% (10007/26007)
Line Coverage: 29.53% (83904/284176)
Region Coverage: 28.62% (43109/150610)
Branch Coverage: 25.22% (21915/86884)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7b0c52fe747cb9749213bb354b91a3b387041af6_7b0c52fe747cb9749213bb354b91a3b387041af6/report/index.html

airborne12
airborne12 requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEED Test

@csun5285
Copy link
Contributor Author

csun5285 commented Dec 6, 2024

run buildall

1 similar comment
@csun5285
Copy link
Contributor Author

csun5285 commented Dec 6, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.53% (10021/26005)
Line Coverage: 29.58% (84119/284399)
Region Coverage: 28.64% (43179/150746)
Branch Coverage: 25.23% (21945/86980)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c3ff1a52ea3fe4887af7dc32f57f9872e0bd939d_c3ff1a52ea3fe4887af7dc32f57f9872e0bd939d/report/index.html

airborne12
airborne12 previously approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR approved by anyone and no changes requested.

@csun5285
Copy link
Contributor Author

csun5285 commented Dec 6, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 6, 2024
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.54% (10022/26002)
Line Coverage: 29.57% (84102/284380)
Region Coverage: 28.65% (43188/150739)
Branch Coverage: 25.24% (21950/86978)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7b3245ef19985d2434e544806aac30e9b976eff5_7b3245ef19985d2434e544806aac30e9b976eff5/report/index.html

airborne12
airborne12 reviewed Dec 10, 2024
View reviewed changes
be/src/olap/tablet.cpp Outdated Show resolved Hide resolved
@csun5285
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/test/olap/rowset/segment_v2/inverted_index/common/inverted_index_gc_binlogs_test.cpp Show resolved Hide resolved
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.86% (10121/26044)
Line Coverage: 29.77% (84933/285320)
Region Coverage: 28.81% (43565/151206)
Branch Coverage: 25.35% (22125/87266)
Coverage Report: http://coverage.selectdb-in.cc/coverage/69546c74764a6b522259cae15bd4c87d76515880_69546c74764a6b522259cae15bd4c87d76515880/report/index.html

@csun5285
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/http/action/download_binlog_action.cpp Show resolved Hide resolved
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.85% (10119/26044)
Line Coverage: 29.77% (84946/285331)
Region Coverage: 28.81% (43560/151213)
Branch Coverage: 25.34% (22116/87270)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a7c6538d1caf8b392d7c42ce9c1497810540bf97_a7c6538d1caf8b392d7c42ce9c1497810540bf97/report/index.html

@csun5285
Copy link
Contributor Author

run buildall

qidaye
qidaye approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.81% (10119/26071)
Line Coverage: 29.77% (85005/285535)
Region Coverage: 28.79% (43575/151329)
Branch Coverage: 25.35% (22135/87332)
Coverage Report: http://coverage.selectdb-in.cc/coverage/80270e677fbe0e03547b258c0e4fbb9c36cba70f_80270e677fbe0e03547b258c0e4fbb9c36cba70f/report/index.html

airborne12
airborne12 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@airborne12 airborne12 merged commit b74b5c6 into apache:master Dec 16, 2024
27 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 16, 2024
@csun5285
[fix] (inverted index) fix index file in gc binlogs (#44994)
ec146c1 
Problem Summary:
1. remove duplicate function `get_segment_index_filepath`
2. fix gc binlogs
@github-actions github-actions bot mentioned this pull request Dec 16, 2024
Merged
airborne12 pushed a commit that referenced this pull request Dec 17, 2024
@github-actions @csun5285
branch-3.0: [fix] (inverted index) fix index file in gc binlogs #44994 (
c2b366e 
#45440)

Cherry-picked from #44994

Co-authored-by: Sun Chenyang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@qidaye qidaye qidaye approved these changes

@airborne12 airborne12 airborne12 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csun5285 @doris-robot @airborne12 @qidaye @wm1581066