Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve](backup) Add config ignore_backup_tmp_partitions #45240

Merged
merged 2 commits into from
Dec 12, 2024
Merged

[improve](backup) Add config ignore_backup_tmp_partitions #45240

merged 2 commits into from
Dec 12, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Dec 10, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

To filter tmp partitions, instead of report exception.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@w41ter
Copy link
Contributor Author

w41ter commented Dec 10, 2024

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@w41ter
Copy link
Contributor Author

w41ter commented Dec 10, 2024

run buildall

@w41ter
[improve](backup) Add config ignore_backup_tmp_partitions
3ccdd2f 
To filter tmp partitions, instead of report exception.
@w41ter
fixup
4e3e61b
@w41ter w41ter force-pushed the add_ignore_backup_tmp_partitions_config branch from 4deced6 to 4e3e61b Compare December 11, 2024 10:34
@w41ter
Copy link
Contributor Author

w41ter commented Dec 11, 2024

run buildall

dataroaring
dataroaring approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@w41ter w41ter merged commit 3af5ef6 into apache:master Dec 12, 2024
28 of 30 checks passed
@w41ter w41ter deleted the add_ignore_backup_tmp_partitions_config branch December 12, 2024 02:36
github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
@w41ter
[improve](backup) Add config ignore_backup_tmp_partitions (#45240)
217b55f 
To filter tmp partitions, instead of report exception.
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Merged
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Dec 12, 2024
@w41ter
[improve](backup) Add config ignore_backup_tmp_partitions (apache#45240)
7a50db4 
To filter tmp partitions, instead of report exception.
@w41ter w41ter mentioned this pull request Dec 12, 2024
Merged
w41ter added a commit that referenced this pull request Dec 13, 2024
@github-actions @w41ter
branch-3.0: [improve](backup) Add config ignore_backup_tmp_partitions #…
40fb69f 
…45240 (#45329)

Cherry-picked from #45240

Co-authored-by: walter <[email protected]>
dataroaring pushed a commit to w41ter/incubator-doris that referenced this pull request Dec 13, 2024
@w41ter @dataroaring
[improve](backup) Add config ignore_backup_tmp_partitions (apache#45240)
334964d 
To filter tmp partitions, instead of report exception.
dataroaring pushed a commit that referenced this pull request Dec 17, 2024
@w41ter
[improve](backup) Add config ignore_backup_tmp_partitions #45240 (#45331
b6a1803 
)

cherry pick from #45240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@w41ter @doris-robot @Yukang-Lian @dataroaring