Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-3330][Feature]add taskmanager.memory.network to TM Memory Options #3340

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

didiaode18
Copy link
Contributor

What changes were proposed in this pull request

Issue Number: close [ISSUE-3330]

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)

@wolfboys
Copy link
Member

Thanks for your contribution! 👏 It looks good, but there is a minor issue with the code style that we need to fix it first.

cd streampark-console/streampark-console-webapp
pnpm lint:eslint

@didiaode18
Copy link
Contributor Author

image
When I ran the pnpm lint:eslint command, I found that the code style error in this line was not caused by the code I merged. I don’t know if my understanding is correct.

@didiaode18
Copy link
Contributor Author

image When I ran the pnpm lint:eslint command, I found that the code style error in this line was not caused by the code I merged. I don’t know if my understanding is correct.

@wolfboys

@wolfboys
Copy link
Member

he code style error in this line was not caused by the code I merged. I don’t know if my understanding is correct.

Oh, thanks for your feedback. I will merge this PR first. Thanks again for your contribution. We are looking forward to your next PR

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit 93330aa into apache:dev Nov 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants