Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-3330][Feature]add taskmanager.memory.network to TM Memory Options #3340

Merged
merged 1 commit into from
Nov 15, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,69 @@ const options = [
}
},
},
{
key: 'taskmanager.memory.network.max',
name: 'taskmanager.memory.network.max',
placeholder: 'Max Network Memory size for TaskExecutors',
description:
'This biggest Network Memory is used for allocation of network buffers',
unit: 'mb',
group: 'taskmanager-memory',
type: 'number',
min: 64,
max: 1024,
step: 1,
defaultValue: 1024,
validator: (_rule, value, callback) => {
if (!value) {
callback(new Error('memory.network.max is required or you can delete this option'));
} else {
callback();
}
},
},
{
key: 'taskmanager.memory.network.min',
name: 'taskmanager.memory.network.min',
placeholder: 'Min Network Memory size for TaskExecutors',
description:
'This minimum Network Memory is used for allocation of network buffers',
unit: 'mb',
group: 'taskmanager-memory',
type: 'number',
min: 64,
max: 1024,
step: 1,
defaultValue: 64,
validator: (_rule, value, callback) => {
if (!value) {
callback(new Error('memory.network.min is required or you can delete this option'));
} else {
callback();
}
},
},
{
key: 'taskmanager.memory.network.fraction',
name: 'taskmanager.memory.network.fraction',
placeholder: 'Fraction of Network Memory size for TaskExecutors',
description:
'The fraction of Network Memory size is used for allocation of network buffers',
unit: 'mb',
group: 'taskmanager-memory',
type: 'number',
min: 0.1,
max: 1,
step: 0.1,
defaultValue: 0.1,
validator: (_rule, value, callback) => {
if (!value) {
callback(new Error('memory.network.fraction is required or you can delete this option'));
} else {
callback();
}
},
},
];

const optionsKeyMapping = new Map<string, Recordable>();
Expand Down