refactor: Fine tuning of the API and SPI #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponses for individual invalid addresses (Alongside a major cleanup)
|
Right now I would first update the test-case xml files for the current state and as soon as that's done, I would try to update the other languages accordingly. |
sruehl
reviewed
Sep 25, 2024
| @@ -37,8 +37,7 @@ | |||
| */ | |||
| public class SymbolicAdsTag implements AdsTag { | |||
|
|
|||
| // TODO: Model the end of this address to allow usage of multi-dimensional arrays. | |||
| private static final Pattern SYMBOLIC_ADDRESS_PATTERN = Pattern.compile("^(?<symbolicAddress>.+)"); | |||
| private static final Pattern SYMBOLIC_ADDRESS_PATTERN = Pattern.compile("^([\\w_]+)(\"[\"\\d*]\")*(\\.(\\w+)(\"[\"\\d*]\")*)*"); | |||
There was a problem hiding this comment.
why did you remove the symbolicAddress reference?
There was a problem hiding this comment.
I'm still working on this.... It's all still WIP.
|
@chrisdutz once you are in a happy state with this PR I can look into adding the Go-Variant for it |
|
Thanks... I just thought I'd push my changes for feedback as early as possible. No need to waste time in something the rest dislikes. |
…ed the PlcValue types)
…n/Protocol so we can start making connection-aware tag-handlers in the future.
…e it in order to fix the UPC-UA tests.
|
So currently it seems that my changes had no effect on C, Python and all other languages, only Go probably needs some adjusting @sruehl would be cool, if you could have a lootk. |
sruehl
approved these changes
Sep 30, 2024
…o hide the implementation detail (Removed the "Default" prefix)
…o hide the implementation detail (Removed the "Default" prefix)
…o hide the implementation detail (Removed the "Default" prefix)
…nstead of calling "handle" in the send-request-expect-response chains.
…nstead of calling "handle" in the send-request-expect-response chains.
…-single-items-read operation.
…tor/api-fine-tuning
…efactor/api-fine-tuning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What started as something to allow returning and handing INVALID_ADDRESS responses for individual items (Currently one address string, that the parser can't handle is enough to fail the entire request).
This required to add a getPlcResponseCode to the PlcTagRequests and to introduce a new set of items for the TagItem and TagValueItems, which allow returning a non-OK return code.
Alongside these changes, I started cleaning things up a little.
In the end I would like to bring back together the Tags and Queries and to only have Tags for both Browse and the other APIs. They could be QueryTags that allow filtering, but in general I think it would be better to only have one type for all APIs.
I could need a bit of help with the other languages.