Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Fine tuning of the API and SPI #1786

Merged
merged 32 commits into from
Oct 2, 2024
Merged

refactor: Fine tuning of the API and SPI #1786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
5236450
refactor: Fine tuning of the API and SPI to allow ILLEGAL_ADDRESS res…
chrisdutz Sep 24, 2024
2d25409
refactor: Major cleanup of the PlcValueHandler
chrisdutz Sep 25, 2024
7b55736
refactor: Major cleanup of the PlcValueHandler
chrisdutz Sep 25, 2024
3884549
refactor: Added more testcases to the PlcValueHandler tests
chrisdutz Sep 25, 2024
f7638e5
Merge remote-tracking branch 'origin/develop' into refactor/api-fine-…
chrisdutz Sep 26, 2024
1c5ffaf
refactor: Added more testcases to the PlcValueHandler tests (Refactor…
chrisdutz Sep 26, 2024
69e78c6
refactor: Added more testcases to the PlcValueHandler tests
chrisdutz Sep 26, 2024
3c0e4ea
refactor: Added more testcases to the PlcValueHandler tests
chrisdutz Sep 26, 2024
8182800
refactor: Added more testcases to the PlcValueHandler tests
chrisdutz Sep 26, 2024
7924a67
refactor: Finished updating the PlcValue types and the single item te…
chrisdutz Sep 27, 2024
b0bdbfe
Merge remote-tracking branch 'origin/develop' into refactor/api-fine-…
chrisdutz Sep 27, 2024
76e6ef3
refactor: Moved the PlcTagHandler from the driver to the PlcConnectio…
chrisdutz Sep 29, 2024
fad287d
fix: Hopefully fixed the time-zone issue in the tests.
chrisdutz Sep 29, 2024
097c9f8
fix: Added back a LegacyPlcValueHandler and made the OPC-UA Driver us…
chrisdutz Sep 29, 2024
16feb76
chore: sync xml
sruehl Sep 30, 2024
afa1765
refactor: Changed the names of the new items when serialized in xml t…
chrisdutz Sep 30, 2024
99018e6
refactor: Changed the names of the new items when serialized in xml t…
chrisdutz Sep 30, 2024
3a99cea
refactor: Changed the names of the new items when serialized in xml t…
chrisdutz Sep 30, 2024
0fd2d9c
fix: Disabled another OPC-UA test, which seems to be randomly failing…
chrisdutz Sep 30, 2024
7c6660c
doc: Updated the RELEASE_NOTES
chrisdutz Sep 30, 2024
5e43fcf
refactor: Renamed some of the variables in the Plc4xProtocolBase class
chrisdutz Sep 30, 2024
af7c030
refactor: Added support to a "toFuture()" method to return a future i…
chrisdutz Oct 1, 2024
42769a3
Merge remote-tracking branch 'origin/develop' into refactor/api-fine-…
chrisdutz Oct 1, 2024
1c2ca38
refactor: Added support to a "toFuture()" method to return a future i…
chrisdutz Oct 1, 2024
6317d31
chore: Updated some generated code.
chrisdutz Oct 1, 2024
aa4f965
refactor: Changed the structure of how to process requests in the ads…
chrisdutz Oct 1, 2024
cdcddcc
fix: Fixed a small bug in the size calculation of an ArrayInfo
chrisdutz Oct 1, 2024
24c9392
Merge remote-tracking branch 'refs/remotes/origin/develop' into refac…
chrisdutz Oct 2, 2024
4de3701
fix: Fixed how Modbus tags produce their array-info
chrisdutz Oct 2, 2024
6de3088
fix: Fixed how Modbus tags produce their array-info
chrisdutz Oct 2, 2024
198e42d
Merge remote-tracking branch 'origin/refactor/api-fine-tuning' into r…
chrisdutz Oct 2, 2024
69ee185
fix: Undid our future-chaining-experiment
chrisdutz Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions RELEASE_NOTES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ Incompatible changes
efficient PlcRawByteArray type is used, that gives users
direct access to the bytes returned from the PLC instead of
a list of PlcValues.
- The builders for read- and write-requests now process tags
and values on a per-field level. If one field has an invalid
address it will now only fail the one item related to that.
Same applies to values. Only the tag who's value was invalid
will be considered failed and no longer an exception should
be thrown.

Bug Fixes
---------
Expand Down
38 changes: 21 additions & 17 deletions plc4go/assets/testing/protocols/ads/DriverTestsuite.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1150,17 +1150,21 @@
<PlcTagRequest>
<tags isList="true">
<hurz>
<SymbolicAdsTag>
<symbolicAddress dataType="string" bitLength="128" encoding="UTF-8">MAIN.hurz_Struct</symbolicAddress>
</SymbolicAdsTag>
<PlcTagItem>
<tag>
<SymbolicAdsTag>
<symbolicAddress dataType="string" bitLength="128" encoding="UTF-8">MAIN.hurz_Struct</symbolicAddress>
</SymbolicAdsTag>
</tag>
</PlcTagItem>
</hurz>
</tags>
</PlcTagRequest>
</PlcReadRequest>
</request>
<values isList="true">
<hurz>
<ResponseItem>
<PlcResponseItem>
<code dataType="string" bitLength="16" encoding="UTF-8">OK</code>
<value>
<PlcStruct>
Expand Down Expand Up @@ -1232,7 +1236,7 @@
</hurz_DATE>
</PlcStruct>
</value>
</ResponseItem>
</PlcResponseItem>
</hurz>
</values>
</PlcReadResponse>
Expand Down Expand Up @@ -1580,12 +1584,12 @@
</PlcReadRequest>
<values isList="true">
<hurz>
<ResponseItem>
<PlcResponseItem>
<code dataType="string" bitLength="16" encoding="UTF-8">OK</code>
<value>
<PlcBOOL dataType="bit" bitLength="1">true</PlcBOOL>
</value>
</ResponseItem>
</PlcResponseItem>
</hurz>
</values>
</PlcReadResponse>
Expand Down Expand Up @@ -1754,20 +1758,20 @@
</PlcReadRequest>
<values isList="true">
<hurz1>
<ResponseItem>
<PlcResponseItem>
<code dataType="string" bitLength="16" encoding="UTF-8">OK</code>
<value>
<PlcBOOL dataType="bit" bitLength="1">true</PlcBOOL>
</value>
</ResponseItem>
</PlcResponseItem>
</hurz1>
<hurz2>
<ResponseItem>
<PlcResponseItem>
<code dataType="string" bitLength="16" encoding="UTF-8">OK</code>
<value>
<PlcBOOL dataType="bit" bitLength="1">true</PlcBOOL>
</value>
</ResponseItem>
</PlcResponseItem>
</hurz2>
</values>
</PlcReadResponse>
Expand Down Expand Up @@ -2040,12 +2044,12 @@
</PlcReadRequest>
<values isList="true">
<hurz1>
<ResponseItem>
<PlcResponseItem>
<code dataType="string" bitLength="16" encoding="UTF-8">OK</code>
<value>
<PlcBOOL dataType="bit" bitLength="1">false</PlcBOOL>
</value>
</ResponseItem>
</PlcResponseItem>
</hurz1>
</values>
</PlcReadResponse>
Expand Down Expand Up @@ -2319,12 +2323,12 @@
</PlcReadRequest>
<values isList="true">
<hurz1>
<ResponseItem>
<PlcResponseItem>
<code dataType="string" bitLength="16" encoding="UTF-8">OK</code>
<value>
<PlcBOOL dataType="bit" bitLength="1">false</PlcBOOL>
</value>
</ResponseItem>
</PlcResponseItem>
</hurz1>
</values>
</PlcReadResponse>
Expand Down Expand Up @@ -2474,12 +2478,12 @@
</PlcReadRequest>
<values isList="true">
<hurz1>
<ResponseItem>
<PlcResponseItem>
<code dataType="string" bitLength="16" encoding="UTF-8">OK</code>
<value>
<PlcBOOL dataType="bit" bitLength="1">false</PlcBOOL>
</value>
</ResponseItem>
</PlcResponseItem>
</hurz1>
</values>
</PlcReadResponse>
Expand Down
18 changes: 11 additions & 7 deletions plc4go/assets/testing/protocols/eip/DriverTestsuite.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,24 +398,28 @@
<PlcTagRequest>
<tags isList="true">
<hurz>
<EipTag>
<node dataType="string" bitLength="40" encoding="UTF-8">%rate</node>
<type dataType="string" bitLength="32" encoding="UTF-8">DINT</type>
<elementNb dataType="uint" bitLength="16">1</elementNb>
</EipTag>
<PlcTagItem>
<tag>
<EipTag>
<node dataType="string" bitLength="40" encoding="UTF-8">%rate</node>
<type dataType="string" bitLength="32" encoding="UTF-8">DINT</type>
<elementNb dataType="uint" bitLength="16">1</elementNb>
</EipTag>
</tag>
</PlcTagItem>
</hurz>
</tags>
</PlcTagRequest>
</PlcReadRequest>
</request>
<values isList="true">
<hurz>
<ResponseItem>
<PlcResponseItem>
<code dataType="string" bitLength="16" encoding="UTF-8">OK</code>
<value>
<PlcDINT dataType="int" bitLength="32">369229824</PlcDINT>
</value>
</ResponseItem>
</PlcResponseItem>
</hurz>
</values>
</PlcReadResponse>
Expand Down
16 changes: 8 additions & 8 deletions plc4go/assets/testing/protocols/modbus/tcp/DriverTestsuite.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,12 @@
</request>
<values isList="true">
<hurz>
<ResponseItem>
<PlcResponseItem>
<code dataType="string" bitLength="16" encoding="UTF-8">OK</code>
<value>
<PlcREAL dataType="float" bitLength="32">3.1415927410125732</PlcREAL>
</value>
</ResponseItem>
</PlcResponseItem>
</hurz>
</values>
</PlcReadResponse>
Expand Down Expand Up @@ -202,15 +202,15 @@
</request>
<values isList="true">
<hurz>
<ResponseItem>
<PlcResponseItem>
<code dataType="string" bitLength="16" encoding="UTF-8">OK</code>
<value>
<PlcList>
<PlcREAL dataType="float" bitLength="32">3.1415927410125732</PlcREAL>
<PlcREAL dataType="float" bitLength="32">3.1415927410125732</PlcREAL>
</PlcList>
</value>
</ResponseItem>
</PlcResponseItem>
</hurz>
</values>
</PlcReadResponse>
Expand Down Expand Up @@ -357,20 +357,20 @@
</request>
<values isList="true">
<hurz1>
<ResponseItem>
<PlcResponseItem>
<code dataType="string" bitLength="16" encoding="UTF-8">OK</code>
<value>
<PlcREAL dataType="float" bitLength="32">3.1415927410125732</PlcREAL>
</value>
</ResponseItem>
</PlcResponseItem>
</hurz1>
<hurz2>
<ResponseItem>
<PlcResponseItem>
<code dataType="string" bitLength="16" encoding="UTF-8">OK</code>
<value>
<PlcREAL dataType="float" bitLength="32">3.1415927410125732</PlcREAL>
</value>
</ResponseItem>
</PlcResponseItem>
</hurz2>
</values>
</PlcReadResponse>
Expand Down
Loading
Loading