Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate React to v18 #1043

Merged
merged 2 commits into from
Oct 12, 2023
Merged

feat: Migrate React to v18 #1043

merged 2 commits into from
Oct 12, 2023

Conversation

cgero-eth
Copy link
Contributor

@cgero-eth cgero-eth commented Sep 28, 2023 •
edited
Loading

Description

  • Update React dependencies to v18
  • Fix re-render issues

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@cgero-eth cgero-eth changed the title WIP: feat: Migrate react to v18 WIP: feat: Migrate React to v18 Sep 28, 2023
@cgero-eth cgero-eth marked this pull request as ready for review October 10, 2023 14:44
@cgero-eth cgero-eth changed the title WIP: feat: Migrate React to v18 feat: Migrate React to v18 Oct 10, 2023
@cgero-eth cgero-eth requested a review from a team October 10, 2023 15:53
@cgero-eth cgero-eth mentioned this pull request Oct 11, 2023
Merged
12 tasks
Fabricevladimir
Fabricevladimir reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew! Lots of changes! Thanks for the updates; left a couple of comments

svgTransform.ts Show resolved Hide resolved
src/containers/actionBuilder/addAddresses/index.tsx Show resolved Hide resolved
src/containers/actionBuilder/mintTokens/index.tsx Show resolved Hide resolved
src/containers/proposalStepper/index.tsx Show resolved Hide resolved
src/context/actions.tsx Show resolved Hide resolved
@Fabricevladimir
Copy link
Contributor

Also, what is up with this list of commits? 🤔

@cgero-eth
Copy link
Contributor Author

cgero-eth commented Oct 12, 2023 •
edited
Loading

Also, what is up with this list of commits? 🤔

I accidentally rebased this branch with the main branch instead of develop, that's why the commit list is messed up 🙈 But we'll squash all the commits of this PR before merging it to develop and we'll only have one commit there.

EDIT: I squashed them locally so that we have now only one nice commit :D

Fabricevladimir
Fabricevladimir approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/containers/actionBuilder/scc/index.tsx Show resolved Hide resolved
@cgero-eth cgero-eth merged commit 64abb3d into develop Oct 12, 2023
5 of 6 checks passed
@cgero-eth cgero-eth deleted the feat-migrate-react-to-v18 branch October 12, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabricevladimir Fabricevladimir Fabricevladimir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgero-eth @Fabricevladimir