Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Header DAO dropdown #36

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Fix: Header DAO dropdown #36

merged 4 commits into from
Oct 12, 2023

Conversation

Fabricevladimir
Copy link
Contributor

@Fabricevladimir Fabricevladimir commented Oct 11, 2023 •
edited by jira bot
Loading

Description

  • updated styling for HeaderDao Dao Credentials dropdown items
  • updated Dropdown component styling when focus and hover states are both active

Task: APP-2462

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@Fabricevladimir Fabricevladimir requested a review from a team October 11, 2023 12:15
@Fabricevladimir Fabricevladimir mentioned this pull request Oct 11, 2023
Merged
12 tasks
cgero-eth
cgero-eth approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @Fabricevladimir 👍🏻

@Fabricevladimir Fabricevladimir merged commit fe46287 into main Oct 12, 2023
5 checks passed
@Fabricevladimir Fabricevladimir deleted the fix/header-dao-dropdown branch October 12, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgero-eth cgero-eth cgero-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fabricevladimir @cgero-eth