Implements basic search frontend #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/arches-lingo into 19-cbyrd-implement-basic-search
…into 19-cbyrd-implement-basic-search
arches_lingo/src/arches_lingo/components/basic-search/BasicSearch.vue
Outdated
Show resolved
Hide resolved
| :loading="isLoading && !isLoadingAdditionalResults" | ||
| :placeholder="$gettext('Quick Search')" | ||
| :pt="{ | ||
| option: { |
There was a problem hiding this comment.
What do you think about doing this instead of the onMounted() in the script tag? This moves the functionality a little closer to what it pertains to.
Suggested change
| option: { | |
| hooks: { onMounted: focusInput }, | |
| option: { |
There was a problem hiding this comment.
This did not seem to work
arches_lingo/src/arches_lingo/components/basic-search/BasicSearch.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/header/SearchDialogue.vue
Outdated
Show resolved
Hide resolved
arches_lingo/src/arches_lingo/components/header/SearchDialogue.vue
Outdated
Show resolved
Hide resolved
jacobtylerwalls
force-pushed
the
jtw/search-backend
branch
from
28dac8e
to
89ef29f
Compare
jacobtylerwalls
force-pushed
the
19-cbyrd-implement-basic-search
branch
from
e22cb90
to
c1a4804
Compare
|
One thing I just happened to notice, the search result bar obscures the controls at smaller widths: |
chrabyrd
force-pushed
the
19-cbyrd-implement-basic-search
branch
from
c1a4804
to
093d808
Compare
…project/arches-lingo into 19-cbyrd-implement-basic-search
…project/arches-lingo into 19-cbyrd-implement-basic-search
…into 19-cbyrd-implement-basic-search
resolved. Ended up finding a pretty good solution that gets rid of some hack. |
jacobtylerwalls
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled
origin/maininto this branch -- it's likely the source of the additional commits