Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements basic search frontend #79
Implements basic search frontend #79
Changes from all commits
644c6fa
0278b76
b8809b6
826b3e6
23319f8
c1b211a
ccedae9
5021c69
8783cdc
760e742
66ccf68
880fc19
18c5de6
fe86962
53e0105
f43f913
818b51f
60a551f
e5be36a
b848642
0a18d49
11f5d6d
bcb29d3
ef9d291
bf65286
1709d49
579b99e
c338dc5
75a897f
311b439
c05e7aa
da209d0
0ec9e8f
fc081dd
91fb56b
ae6fd63
87ac1a6
6a5f68b
c1aa03a
0b43d2d
89214ac
27f2770
6b64f06
b29b9c0
639efe5
fae465e
ecab8f8
5c48d38
2308eef
aff792c
85cca11
d08c429
539147e
e54f706
ed16aa0
8d75b68
55f6eda
af32bc5
823b9d4
8cb74a5
8a3991c
4dcd7f3
bf868db
744880a
ab3d427
c166e83
d160f0d
1ddb5a4
7df77dc
890e029
9abcb33
1aae8a2
3b2a7f8
a3b6040
2db979e
2c7bee7
f8f6ae7
cd1b7c9
38dd2b2
3c039e5
eb08e4c
0bd47c2
4c717a1
68735d8
1cf3755
10855c0
482099d
e8b3079
1613cc6
3c0565a
452affa
4ffa6d4
e2d723c
9a702ae
093d808
7866d33
bedbb80
a0214d6
c7ec5df
e9de73d
2635a98
14de455
6fe8434
cede13e
aa1a902
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about doing this instead of the onMounted() in the script tag? This moves the functionality a little closer to what it pertains to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This did not seem to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as I get used to PrimeVue, is this being used instead of
:empty-selection-message=...
because we're templating#option
and thus need to template all slots? Or can you just template one slot?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for a few reasons. basically it's 6-in-one-half-dozen-the-other for me, in that both solutions take about the same LoE and lines of code.
Using
:empty-selection-message=
still needs stylingwhich can be done, but then why not just slot out a div and make it more versatile for potential future adjustments. idk what if I wanna include a gif of a sad cat or something?