chore(deps): use docker/login-action consistently instead of Azure/docker-login

[agilgur5]

Follow-up to #12775

Motivation

• Azure/docker-login seems to have been the first one to have been added in chore: Use GitHub Actions to build Docker Images to allow publishing Windows Images #3291, then docker/login-action was added after in chore(build): Pre-push temporary manifest with linux/amd64. Fixes #4062 #4127, but currently both are being used without consistency

• Azure/docker-login is not maintained much, with the last release ~1.5 years ago and no update to Node v20 as of yet, despite issues and PRs on it from a few months ago (Node 16 is deprecated, move to node 20 Azure/docker-login#63, Update to nodejs v20 Azure/docker-login#64)

Modifications

• consistently use docker/login-action, which is more maintained, more centralized, more commonly used, and not on EoL Node
  • last release a few months ago, last commit a few weeks ago

Verification

This only runs during releases, so a bit hard to test 😕

[terrytangyuan]

Why not combining with #12775?

[agilgur5]

Why not combining with #12775?

Well, to begin with, that one was made a few days beforehand (both made 2+ weeks ago), and has now been merged earlier too.

Otherwise there are purposes are different, per PR title and the "Motivation" section in each. That one is an update, this one is changing the action itself to a different one (which happens to be more updated), as well as the configuration for the new action. That also entails different risk levels (updating typically being less risky than changing a dep wholesale).

Similar to mine and other maintainers' PRs in the past, they are also independent of each other (or "atomic" as another term maintainers have used) and so don't need to be tied together -- and it would be better practice not to do so.

[agilgur5]

Merged main for new PR checks per #13027

[agilgur5]

Huh so this did partially fail on release on main:

Run echo $(jq -c '. + { "experimental": "enabled" }' ${DOCKER_CONFIG}/config.json) > ${DOCKER_CONFIG}/config.json
jq: error: Could not open file /config.json: No such file or directory
/home/runner/work/_temp/3b2a11f7-f9e3-4c1e-8ab2-431101712831.sh: line 1: /config.json: Permission denied

All the builds and pushes of images worked, it's the manifest push that failed; i.e. this line, which I didn't change in the PR.

It seems like ${DOCKER_CONFIG} is empty per the error message 🤔 So it may have only been set by Azure/docker-login, which means the code was relying on an env var side effect, if I'm understanding correctly.
The default is ~/.docker/config.json so this may be easily replaceable

I wish the release GHA workflow was easier to test though 😕

[agilgur5]

The default is ~/.docker/config.json so this may be easily replaceable

Added this as a default in #13155