fix(release): set $DOCKER_CONFIG if unset
#13155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It seems like `Azure/docker-login` may have set this env var and so when that was changed, this line errored out
- so set a default in case it is unset
- Per [Docker's docs](https://docs.docker.com/engine/reference/commandline/cli/#environment-variables), the default is `~/.docker/config.json` (can also confirm locally)
Signed-off-by: Anton Gilgur <[email protected]>
terrytangyuan
approved these changes
Jun 8, 2024
|
All green on |
agilgur5
added a commit
that referenced
this pull request
Aug 1, 2024
Signed-off-by: Anton Gilgur <[email protected]> (cherry picked from commit effcab7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12791 (comment)
Motivation
Per the linked comment above, it seems like
Azure/docker-loginmay have set this env var and so when that was changed todocker/login-action, this line errored outModifications
$DOCKER_CONFIGin case it is unset~/.docker/config.json(can also confirm locally)Verification
This new line runs locally for me:
and
$DOCKER_CONFIGis unset without itBut testing the entire GHA workflow is unfortunately very non-trivial 😕