-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(cli): add examples for argo archive list
with option explanations
#13662
docs(cli): add examples for argo archive list
with option explanations
#13662
Conversation
Signed-off-by: leehosu <[email protected]>
Signed-off-by: leehosu <[email protected]>
Signed-off-by: leehosu <[email protected]>
Signed-off-by: leehosu <[email protected]>
argo archive list
with option explanations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. Please try to follow the issue description and it's recommendations closely, see in-line comments below
Verification
Added examples for the argo archive list command.
Verification means checking that these examples work and that the changes are tested / pass CI
Signed-off-by: leehosu <[email protected]>
Signed-off-by: leehosu <[email protected]>
Signed-off-by: leehosu <[email protected]>
Signed-off-by: leehosu <[email protected]>
Signed-off-by: leehosu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some grammar and style changes below, plus more consistency suggestions.
Also you have not yet corrected your "Verification" section, per my previous comment. You should test the example commands you've listed and confirm they work.
Your other PR #13668 does not have a proper "Verification" section either
Co-authored-by: Anton Gilgur <[email protected]> Signed-off-by: l2h <[email protected]>
Codegen is failing correctly, you'll need to apply my previous suggestion to the generated CLI docs as well. I did not mention that initially as that was intended as a learning opportunity for you to figure out on your own. As you've merged |
Signed-off-by: leehosu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks
Fixes #11898
Motivation
Modify the
argo archive list
command for more informationModifications
Added examples for the argo archive list command.
Verification
run
argo archive list -h