Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(controller)!: Key-only artifacts. Fixes #3184 #4618

Merged
merged 16 commits into from
Jan 20, 2021
Merged

feat(controller)!: Key-only artifacts. Fixes #3184 #4618

merged 16 commits into from
Jan 20, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Nov 30, 2020 •
edited
Loading

Signed-off-by: Alex Collins [email protected]

Checklist:

Fixes #3184

  • Allow users to specify artifacts only using the key, bucket and endpoint are taken from the configuration, reducing repetition.
  • Node status only includes the key if needed. Reducing YAML size for large workflows.
  • Significant refactoring.
  • Lots of new tests.

@alexec alexec marked this pull request as ready for review December 1, 2020 00:59
@alexec alexec closed this Dec 5, 2020
@alexec alexec deleted the key branch December 5, 2020 00:35
@alexec alexec restored the key branch December 9, 2020 21:14
@alexec alexec reopened this Dec 9, 2020
@sarabala1979 sarabala1979 removed their assignment Dec 11, 2020
@alexec
Copy link
Contributor Author

alexec commented Dec 18, 2020

Closing PR. Will need to rebase after code migration.

@alexec alexec closed this Dec 18, 2020
@alexec alexec reopened this Jan 3, 2021
@alexec alexec added this to the v3.0 milestone Jan 3, 2021
@fvdnabee fvdnabee mentioned this pull request Jan 12, 2021
Closed
@sarabala1979 sarabala1979 self-assigned this Jan 12, 2021
@alexec alexec mentioned this pull request Jan 19, 2021
Closed
@alexec alexec linked an issue Jan 19, 2021 that may be closed by this pull request
Aggregating the output artifacts of parallel steps (fan-in) #934
Closed
@alexec alexec changed the title feat(controller): Key-only artifacts. Fixes #3184 feat(controller)!: Key-only artifacts. Fixes #3184 Jan 19, 2021
@sarabala1979
Copy link
Member

@alexec Can we add the example and documents?

@alexec
Copy link
Contributor Author

alexec commented Jan 19, 2021 •
edited
Loading

  • add example usage
  • update map-reduce example to use this

@alexec
Merge branch 'master' into key
ad3b4da 
Signed-off-by: Alex Collins <[email protected]>
@alexec
docs
eaff80a 
Signed-off-by: Alex Collins <[email protected]>
@alexec
Copy link
Contributor Author

alexec commented Jan 19, 2021

@sarabala1979 docs and examples added.

@alexec
🔑 M docs/fields.md
c4b959c 
Signed-off-by: Alex Collins <[email protected]>
sarabala1979
sarabala1979 reviewed Jan 20, 2021
View reviewed changes
pkg/apis/workflow/v1alpha1/workflow_types.go
a.HDFS.HasLocation() ||
a.OSS.HasLocation() ||
a.GCS.HasLocation()
func (a *ArtifactLocation) Get() ArtifactLocationType {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much clear

sarabala1979
sarabala1979 approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@sarabala1979 sarabala1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexec alexec linked an issue Jan 20, 2021 that may be closed by this pull request
Cannot specify key for input artifact (without full artifact location) #3307
Closed
@alexec alexec merged commit c8215f9 into argoproj:master Jan 20, 2021
@alexec alexec deleted the key branch January 20, 2021 19:10
This was referenced Jan 25, 2021
Closed
Closed
@Bobgy Bobgy mentioned this pull request Feb 3, 2021
Open
@Subreptivus Subreptivus mentioned this pull request Jun 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarabala1979 sarabala1979 sarabala1979 approved these changes

Assignees

@sarabala1979 sarabala1979

Labels
None yet
Projects
None yet
Milestone
v3.0
2 participants
@alexec @sarabala1979