Update composer deps and update php-cs-fixer conf #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice @anvit! At the time, we decided to follow the rules giving by php-cs-fixer and the community as much as possible and avoid our own opinions/discussions. I'd try to follow those new rules when possible too. I'd suggest you continue this PR and enable them one by one to see what they do and, unless you have a really strong argument against them, follow the default as much as possible. Check the comment in the config to know why we changed only one rule. Maybe with the new version that rule could be restored to the default too. |
jraddaoui
approved these changes
Oct 17, 2024
| @@ -116,7 +116,7 @@ public function validateFilename($filename): string | |||
| return $filename; | |||
| } | |||
|
|
|||
| public function setOptions(array $options = null): void | |||
| public function setOptions(?array $options = null): void | |||
There was a problem hiding this comment.
TIL about nullable type syntactic sugar.
| @@ -199,7 +199,7 @@ | |||
| <section class="actions"> | |||
| <ul> | |||
|
|
|||
| <?php if (QubitAcl::check($resource, 'update') || (QubitAcl::check($resource, 'translate'))) { ?> | |||
| <?php if (QubitAcl::check($resource, 'update') || QubitAcl::check($resource, 'translate')) { ?> | |||
There was a problem hiding this comment.
Amazing how many unneeded parenthesis we had.
Update composer dependencies: - jasig/phpcas is no longer maintained. apereo/phpcas is the suggested replacement. - Updating to php-cs-fixer 3.64.0 introduces some new rules which would lead to changes in over ~400 files. Selectively changing or turning off some of these rules that would lead to problems.
anvit
force-pushed
the
dev/update-composer-deps
branch
from
14570e7
to
59ac8ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update composer dependencies: