Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for ASDF standard 1.6.0 #219

Merged
merged 16 commits into from
Mar 10, 2024
Merged

Update for ASDF standard 1.6.0 #219

merged 16 commits into from
Mar 10, 2024

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Feb 7, 2024

This PR updates this asdf extension for new versions of:

  • asdf-standard
  • asdf-coordinates-schemas
  • asdf-transform-schemas

CompoundManifestExtension was removed (as it is no longer required)

and updates the CI to account for:

  • astropy dev requiring python 3.10
  • remove testing against a bunch of random old numpy versions
  • separate astropy-dev and numpy-dev testing
  • missing python 3.12 testing

a pytest upper pin was added to deal with: scientific-python/pytest-doctestplus#243
when merged an issue can be opened to track removal of this pin
EDIT: a new version of pytest-doctestplus was released that fixed the issue

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.63%. Comparing base (448542b) to head (34a791d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
- Coverage   98.64%   98.63%   -0.02%     
==========================================
  Files          55       54       -1     
  Lines        2062     2044      -18     
==========================================
- Hits         2034     2016      -18     
  Misses         28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram changed the title TEST: update for 1.6.0 standard Update for ASDF standard 1.6.0 Mar 9, 2024
@braingram braingram marked this pull request as ready for review March 9, 2024 16:43
@braingram braingram requested a review from nden March 9, 2024 16:43
@braingram
Copy link
Contributor Author

The MaskedArray failure with numpy 2.0 is unrelated and addressed in: asdf-format/asdf#1769

Copy link
Contributor

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@braingram braingram merged commit 050ef58 into astropy:main Mar 10, 2024
30 of 32 checks passed
@braingram braingram deleted the split_core branch March 10, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants