-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop py39 try to fix oldestdeps #232
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
- Coverage 97.95% 97.90% -0.05%
==========================================
Files 54 54
Lines 2050 2050
==========================================
- Hits 2008 2007 -1
- Misses 42 43 +1 ☔ View full report in Codecov by Sentry. |
I think the coverage drop is due to vestigial code that we can remove since we're dropping older versions. I'd like to get this in to test #230 so will make an issue to track a more thorough search of our code for conditionals we can remove now that we don't support certain versions. |
@zacharyburnett I can't request your review so I pinged @nden instead. This should allow us to test your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with my limited expertise in this). Seems pretty straightforward though.
This PR drops a few old versions of:
This PR also fixes the oldestdeps job which appears to have never worked due to a typos,
oldestdep
instead ofoldestdeps
(andparallels
instead ofparallel
):asdf-astropy/.github/workflows/ci.yml
Line 103 in dab5b4d
When it
oldestdeps
working with this PR and the numpy version was bumped the CI showed failures due to the old astropy (5.0.4). These were addressed by bumping astropy to 5.2.0.Fixes #231