Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add servers #1927

Closed
wants to merge 14 commits into from
Closed

docs: add servers #1927

wants to merge 14 commits into from

Conversation

kakabisht
Copy link
Contributor

@kakabisht kakabisht commented Jul 11, 2023 •
edited
Loading

Description : Add Servers

  • Define servers
  • Add server reference

Refer: #1714

@netlify
Copy link

netlify bot commented Jul 11, 2023 •
edited
Loading

✅ Deploy Preview for shimmering-choux-eb0798 ready!

Name Link
🔨 Latest commit 43d42fa
🔍 Latest deploy log https://app.netlify.com/sites/shimmering-choux-eb0798/deploys/655f867ef98867000893fbd5
😎 Deploy Preview https://deploy-preview-1927--shimmering-choux-eb0798.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

AnimeshKumar923
AnimeshKumar923 reviewed Jul 22, 2023
View reviewed changes
Copy link
Contributor

@AnimeshKumar923 AnimeshKumar923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good till now. 👍

@kakabisht
Copy link
Contributor Author

Hi, could you assign this to me? @alequetzalli

@jonaslagoni
Copy link
Member

Hey @kakabisht, any update here? 🙂

@kakabisht
Copy link
Contributor Author

Yes, @jonaslagoni, I am finishing up some minor changes. The following PR's are ready for tech review:

@quetzalliwrites quetzalliwrites added 📑 docs area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. gsod This label should be used for issues or discussions related to ideas for Google Season of Docs labels Sep 1, 2023
@mhmohona mhmohona mentioned this pull request Sep 5, 2023
Closed
@kakabisht kakabisht marked this pull request as ready for review September 15, 2023 10:06
quetzalliwrites
quetzalliwrites requested changes Nov 17, 2023
View reviewed changes
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review left at long last, @kakabisht 😄✌🏽

@derberg derberg deleted the branch asyncapi:next-major-spec December 5, 2023 09:40
@derberg derberg closed this Dec 5, 2023
@mhmohona mhmohona mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnimeshKumar923 AnimeshKumar923 AnimeshKumar923 left review comments

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve

@quetzalliwrites quetzalliwrites Awaiting requested review from quetzalliwrites

Assignees

@kakabisht kakabisht

Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 📑 docs gsod This label should be used for issues or discussions related to ideas for Google Season of Docs
Projects
AsyncAPI Docs Board
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kakabisht @jonaslagoni @quetzalliwrites @AnimeshKumar923 @derberg