-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating broken notebooks #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Giovanni! Thanks for all the work. I like the script thing in the notebooks :)
As for the notebooks you think we should remove, I'm currently going through all the notebooks, seeing if they're worth keeping and writing some documentation on the ones that are. My point is: we can discuss the notebooks worth keeping in my next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work @Soap2G! Please find some comments
Regarding the notebooks discussion, I'll address that in @marianaiv's PR, thanks! |
Comments are now addressed.
Since these notebooks are already mentioned as faulty in the description, I would go ahead and address these two issues in the next iteration, since PR #58 is depending on this. |
This PR addresses a few straightforward code inconsistencies related to the notebooks.
List of notebooks fixed is at this link
Upgrades
I have:
environment.yml
to account for missing packages in the docker image (e.g.hist
anddask
), which were causing the failure of the pipelinedata_all = data_all.append(data) ---> data_all = pd.concat([data_all, data], ignore_index=True)
) related to old packages.environment.yml
file, through a setup cell that can be seen in this example notebook.The script is like this:
ToDos
There are two items yet to be addressed:
13-TeV-examples/uproot_python/ttZ_ML_from_root.ipynb
takes a LOT of time to run. This is due to the large number of events that have to be processed. It is ~1h run time and then it crashes. I'm not sure it's worth to keep it in the list of notebooks to be run.13-TeV-examples/uproot_python/Dark_Matter_Machine_Learning.ipynb
, that has blank spaces, to be filled by the user. This cannot be run by definition, so I suggest we take it out of the list.fsspec
, for which come samples return aFileNotFound
error even if they do exist.I'll leave these items to @AntonioJC and Reina, given that they are already working on that.