Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure correct float types with numpy 2.0 #34

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Ensure correct float types with numpy 2.0 #34

merged 1 commit into from
Jul 4, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Jul 4, 2024

This adjusts the code and some tests to handle the new behavior of numpy 2.0 regarding float values:

  • ensure dtype float instead of np.float64
  • reduce precision of a test from 7 to 6 decimals

@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (4cf278e) to head (3c9f4de).

Additional details and impacted files
Files Coverage Δ
auglib/core/utils.py 100.0% <100.0%> (ø)

@hagenw hagenw mentioned this pull request Jul 4, 2024
Closed
@hagenw hagenw requested a review from audeerington July 4, 2024 11:58
audeerington
audeerington approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@audeerington audeerington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this!

@hagenw hagenw merged commit aa87c89 into main Jul 4, 2024
9 checks passed
@hagenw hagenw deleted the fix-numpy2 branch July 4, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audeerington audeerington audeerington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hagenw @audeerington