-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Procedural Wood #1404
base: adsk_contrib/dev
Are you sure you want to change the base?
Procedural Wood #1404
Conversation
Add a 3d wood material node graph (wood3d) which includes following custom nodes/node graphs as its components: - two custom noise node (wood3d_util_noise1d and wood3d_util_hashnoise2d), - a custom node for wood pore calculation (wood3d_util_pore_impulse), and - many sub-graphs that improve readability / help reduce complexity of the wood3d node graph. This commit also contains a 3dwood_prests.mtlx which has many pre-defined parameters that helps to create different types of wood.
Update some ui input limitation in node def and add a hard limitation to pore_cell_dim since it may cause divide by zero issue.
--> | ||
<nodedef name="ND_wood3d" node="wood3d" nodegroup="texture3d"> | ||
<input name="seed" uiname="Wood generation seed" uifolder="Wood Space Settings" type="float" value="2" uimin="0" uisoftmax="4096" xpos="-107.971016" ypos="-45.672413" /> | ||
<input name="scale" unittype="distance" uivisible="false" uiname="Scale (should not be changed by user)" uifolder="Wood Space Settings" type="float" value="0.1" uimin="0" uisoftmax="10" xpos="-110.057968" ypos="-47.879311" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove "(should not be changed by the user)". It's legit for the user to adjust the overall size if desired.
Why is the default 0.1? It should be 1.0.
I verified that with scale 1.0 and units in cm, the rings are correctly spaced.
<input name="early_color" type="color3" interfacename="early_color" /> | ||
<input name="radius" type="float" nodename="final_radius" /> | ||
</wood3d_util_earlywood_color> | ||
<wood3d_util_latewood_color name="latecolor_prelin" type="color3" xpos="-63.217392" ypos="-46.258621"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo "prelin", also line 1606
I see the comments on defs file about the subgraphs with single-use. I'm still of the opinion we should remove them. |
Just for the record (no need to add anything now). The defs should include a namespace="adsk" like for Prism nodes when final. |
We have a few instances of Graph Editor auto-naming of nodes that are misleading (in sub-graphs). |
- Fix scale's description and the default value. - Fix a "prelin" typo. - Rename misleading node names. Any node ending with "_vectorxx" or "_floatxx" is renamed to "_vector_xx" and "_float_xx".
- Rename nodes in a better way. - Move "wood3d_util_pore_color" from a predefined graph to the main graph because it's a very small graph .
Add a procedural wood material node graph (wood3d) which includes following custom nodes/node graphs as its components:
This commit also contains a 3dwood_prests.mtlx which has many pre-defined parameters that helps to create different types of wood.