revert: revert "refactor(autoware_map_msgs): modify pcd metadata msg (#7852)" #8180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsudome-r
requested review from
kosuke55,
Shin-kyoto,
amc-nu,
badai-nguyen,
yukkysaito,
anhnv3991,
KYabuuchi,
Motsu-san,
RyuYamamoto,
SakodaShintaro,
TaikiYamada4,
YamatoAndo and
isamu-takagi
as code owners
github-actions
bot
added
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
…efoundation#7852)" This reverts commit 8ea7de7. Signed-off-by: mitsudome-r <[email protected]>
mitsudome-r
force-pushed
the
revert/pr7852
branch
from
7ee0293
to
a5c001f
Compare
mitsudome-r
changed the title
SakodaShintaro
approved these changes
Jul 25, 2024
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
mitsudome-r
force-pushed
the
revert/pr7852
branch
from
2b5ce21
to
e2dda2e
Compare
mitsudome-r
added
the
tag:run-build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8180 +/- ##
==========================================
- Coverage 29.22% 29.21% -0.02%
==========================================
Files 1596 1601 +5
Lines 117690 117739 +49
Branches 50706 50708 +2
==========================================
Hits 34400 34400
- Misses 74075 74124 +49
Partials 9215 9215
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yukkysaito
approved these changes
Jul 25, 2024
chihungtzeng
pushed a commit
to chihungtzeng/autoware.universe
that referenced
this pull request
Jul 26, 2024
…utowarefoundation#7852)" (autowarefoundation#8180) Signed-off-by: Ryohsuke Mitsudome <[email protected]>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Jul 28, 2024
…utowarefoundation#7852)" (autowarefoundation#8180) Signed-off-by: Ryohsuke Mitsudome <[email protected]>
esteve
pushed a commit
to esteve/autoware.universe
that referenced
this pull request
Aug 13, 2024
…utowarefoundation#7852)" (autowarefoundation#8180) Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8ea7de7.
This is a breaking change to autoware_msgs API and since autoware_msgs started to do version control, we should wait until autoware_msgs releases a new version with the new API.
Description
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.