-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reaction_analyzer): fix unreadVariable #8373
fix(reaction_analyzer): fix unreadVariable #8373
Conversation
Signed-off-by: kobayu858 <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: kobayu858 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8373 +/- ##
=======================================
Coverage ? 23.72%
=======================================
Files ? 1379
Lines ? 101368
Branches ? 38515
=======================================
Hits ? 24047
Misses ? 74866
Partials ? 2455
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please confirm the PR. Thank you very much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to define current_distance
before the loop. LGTM. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the inconvenience, it seems there is another PR which proposed almost same changes:
making const double
is better so IMO we can close this PR.
@brkay54 |
Description
This is a fix based on cppcheck unreadVariable warnings.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.