Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ad_api_visualizers): rework parameter #8690

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

prakash-kannaiah
Copy link
Contributor

Description


Implement the ROS Node configuration layout described in Autoware Foundation Discussion #3371 for the ad_api_visualizers package.

  • Remove duplication of parameter declaration between the source code and the parameter file.
  • Remove the default value from the source code to ensure all parameter values are passed from the parameter files.
  • Use types that match those returned from declare_parameter() to prevent confusion and potential coding errors.
  • Move the default parameter file to a standardized location. Use the JSON Schema for that.

Tests performed


Package built locally with colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to ad_api_visualizers

Pre-review checklist for the PR author


The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers


The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author


The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone with write access can merge the PR.

Copy link

github-actions bot commented Aug 30, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Aug 30, 2024
@prakash-kannaiah prakash-kannaiah deleted the refactor/ad_api_visualizers branch August 30, 2024 12:48
@prakash-kannaiah prakash-kannaiah restored the refactor/ad_api_visualizers branch August 30, 2024 15:23
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the parameter file is not installed, the data_files in setup.py should be as follows:

    data_files=[
        ("share/ament_index/resource_index/packages", [f"resource/{package_name}"]),
        (f"share/{package_name}", ["package.xml"]),
        (f"share/{package_name}/launch", [f"launch/{package_name}.launch.xml"]),
        (f"share/{package_name}/config", [f"config/{package_name}.param.yaml"]),
    ],

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oguzkaganozt oguzkaganozt enabled auto-merge (squash) September 4, 2024 13:13
@isamu-takagi isamu-takagi changed the title refactor(ad_api_visualizers):rework parameter refactor(ad_api_visualizers): rework parameter Sep 5, 2024
auto-merge was automatically disabled September 6, 2024 06:55

Head branch was pushed to by a user without write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants