-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ad_api_visualizers): rework parameter #8690
base: main
Are you sure you want to change the base?
refactor(ad_api_visualizers): rework parameter #8690
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
system/default_ad_api_helpers/ad_api_visualizers/launch/ad_api_visualizers.launch.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the parameter file is not installed, the data_files
in setup.py
should be as follows:
data_files=[
("share/ament_index/resource_index/packages", [f"resource/{package_name}"]),
(f"share/{package_name}", ["package.xml"]),
(f"share/{package_name}/launch", [f"launch/{package_name}.launch.xml"]),
(f"share/{package_name}/config", [f"config/{package_name}.param.yaml"]),
],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…_visualizers.launch.xml Co-authored-by: Takagi, Isamu <[email protected]>
51aaeaa
to
4c31b70
Compare
Head branch was pushed to by a user without write access
Description
Implement the ROS Node configuration layout described in Autoware Foundation Discussion #3371 for the
ad_api_visualizers
package.Tests performed
Package built locally with
colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to ad_api_visualizers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone with write access can merge the PR.