feat(object_merger): merge known objects #8718
+113
−18
Draft
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Sep 7, 2024 in 36s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.56 (8.49 -> 7.93)
- Declining Code Health: 2 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method object_association_merger_node.cpp: ObjectAssociationMergerNode::objectsCallback
- Bumpy Road Ahead object_association_merger_node.cpp: ObjectAssociationMergerNode::objectsCallback
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
ObjectAssociationMergerNode::objectsCallback increases in cyclomatic complexity from 19 to 27, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Bumpy Road Ahead
ObjectAssociationMergerNode::objectsCallback increases from 4 to 6 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 308 in perception/autoware_object_merger/src/object_association_merger_node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Deep, Nested Complexity
ObjectAssociationMergerNode::objectsCallback increases in nested complexity depth from 4 to 5, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.
Check notice on line 85 in perception/autoware_object_merger/src/object_association_merger_node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Excess Number of Function Arguments
isKnownObjectOverlapped has 6 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Loading