Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ad_api_adaptors): rework parameter #8796

Merged

Conversation

prakash-kannaiah
Copy link
Contributor

Description


Implement the ROS Node configuration layout described in Autoware Foundation Discussion #3371 for the ad_api_adaptors package.

  • Remove duplication of parameter declaration between the source code and the parameter file.
  • Remove the default value from the source code to ensure all parameter values are passed from the parameter files.
  • Use types that match those returned from declare_parameter() to prevent confusion and potential coding errors.
  • Move the default parameter file to a standardized location. Use the JSON Schema for that.

Tests performed


No.

Pre-review checklist for the PR author


The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers


The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author


The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone with write access can merge the PR.

@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@isamu-takagi isamu-takagi added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.02%. Comparing base (9f7ba86) to head (9e96065).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8796      +/-   ##
==========================================
- Coverage   28.02%   24.02%   -4.00%     
==========================================
  Files        1316     1402      +86     
  Lines       98601   101815    +3214     
  Branches    39771    38637    -1134     
==========================================
- Hits        27636    24466    -3170     
- Misses      70819    74893    +4074     
- Partials      146     2456    +2310     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 24.03% <ø> (-4.00%) ⬇️ Carriedforward from 16c0a05

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi enabled auto-merge (squash) September 13, 2024 01:23
…h/autoware.universe into refactor/ad_api_adaptors
auto-merge was automatically disabled September 13, 2024 04:06

Head branch was pushed to by a user without write access

@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Sep 13, 2024
@isamu-takagi isamu-takagi merged commit 897e2a9 into autowarefoundation:main Sep 24, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants