-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ad_api_adaptors): rework parameter #8796
refactor(ad_api_adaptors): rework parameter #8796
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8796 +/- ##
==========================================
- Coverage 28.02% 24.02% -4.00%
==========================================
Files 1316 1402 +86
Lines 98601 101815 +3214
Branches 39771 38637 -1134
==========================================
- Hits 27636 24466 -3170
- Misses 70819 74893 +4074
- Partials 146 2456 +2310
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…h/autoware.universe into refactor/ad_api_adaptors
Head branch was pushed to by a user without write access
Description
Implement the ROS Node configuration layout described in Autoware Foundation Discussion #3371 for the
ad_api_adaptors
package.Tests performed
No.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone with write access can merge the PR.