-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(traffic_light_map_based_detector): rework parameter #8934
Open
prakash-kannaiah
wants to merge
11
commits into
autowarefoundation:main
Choose a base branch
from
prakash-kannaiah:refactor/traffic_light_map_based_detector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor(traffic_light_map_based_detector): rework parameter #8934
prakash-kannaiah
wants to merge
11
commits into
autowarefoundation:main
from
prakash-kannaiah:refactor/traffic_light_map_based_detector
+111
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakash-kannaiah
requested review from
miursh,
tzhong518 and
yukkysaito
as code owners
September 21, 2024 03:50
github-actions
bot
added
type:documentation
Creating or refining documentation. (auto-assigned)
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
tag:require-cuda-build-and-test
labels
Sep 21, 2024
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
YoshiRi
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR, could you check some comments?
...autoware_traffic_light_map_based_detector/launch/traffic_light_map_based_detector.launch.xml
Outdated
Show resolved
Hide resolved
...autoware_traffic_light_map_based_detector/launch/traffic_light_map_based_detector.launch.xml
Outdated
Show resolved
Hide resolved
...autoware_traffic_light_map_based_detector/launch/traffic_light_map_based_detector.launch.xml
Outdated
Show resolved
Hide resolved
…ight_map_based_detector.launch.xml Co-authored-by: Yoshi Ri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
tag:require-cuda-build-and-test
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in Autoware Foundation Discussion #3371 for the
traffic_light_map_based_detector
package.Tests performed
No.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone with write access can merge the PR.