Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mrm_comfortable_stop_operator): rework parameter #8936

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

prakash-kannaiah
Copy link
Contributor

@prakash-kannaiah prakash-kannaiah commented Sep 21, 2024

Description


Implement the ROS Node configuration layout described in Autoware Foundation Discussion #3371 for the mrm_comfortable_stop_operator package.

  • Remove duplication of parameter declaration between the source code and the parameter file.
  • Remove the default value from the source code to ensure all parameter values are passed from the parameter files.
  • Use types that match those returned from declare_parameter() to prevent confusion and potential coding errors.
  • Move the default parameter file to a standardized location. Use the JSON Schema for that.

Tests performed


No.

Pre-review checklist for the PR author


The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers


The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author


The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone with write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:system System design and integration. (auto-assigned) labels Sep 21, 2024
Copy link

github-actions bot commented Sep 21, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@prakash-kannaiah prakash-kannaiah changed the title refactor(refactor/mrm_comfortable_stop_operator): rework parameter refactor(mrm_comfortable_stop_operator): rework parameter Sep 21, 2024
@mitsudome-r mitsudome-r added tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 26.30%. Comparing base (a3c7ede) to head (60202e8).

Files with missing lines Patch % Lines
...op_operator/mrm_comfortable_stop_operator_core.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8936      +/-   ##
==========================================
- Coverage   27.37%   26.30%   -1.07%     
==========================================
  Files        1302     1314      +12     
  Lines       95845    96846    +1001     
  Branches    39146    39290     +144     
==========================================
- Hits        26238    25477     -761     
- Misses      66925    68679    +1754     
- Partials     2682     2690       +8     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 26.30% <ø> (-1.07%) ⬇️ Carriedforward from 2b0a000

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r
Copy link
Member

@prakash-kannaiah
Thank you for the PR. However, the PR seems to be failing in the CI for DCO check. When you push commits, could you push with signed-off commits?

You should be able to sign off the commits for this PR by running the following command:
git rebase -i --signoff origin/main

@prakash-kannaiah prakash-kannaiah force-pushed the refactor/mrm_comfortable_stop_operator branch from 0feb6b7 to 58bd1ec Compare September 29, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants