-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(package.xml): bump version to 0.38.0 #9266
Conversation
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
@mitsudome-r @xmfcx A branch protection rule is needed for the |
@youtalk -san, I can add the branch protection rules.
Why? We could have the releases and version control without needing merge commits. I've checked the practices utilized by many official ROS 2 packages and none of them allowed merge commits. I'd much prefer not to complicate the commit history by allowing merge commits. And keep a linear history for main and ros-distro branches. Exampleshttps://github.com/ros2/rosbag2 https://github.com/ros2/ros2cli https://github.com/ros2/rclcpp cc. @mitsudome-r |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## humble #9266 +/- ##
=======================================
Coverage 28.76% 28.76%
=======================================
Files 1314 1314
Lines 101743 101743
Branches 39592 39592
=======================================
Hits 29263 29263
Misses 69474 69474
Partials 3006 3006
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@xmfcx If we merge all patch PRs that exist only in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that the changes are only made to package.xml and CHANGELOG.rst.
For the package.xml, the PR is only updating version to 0.38.
I haven't looked into all the details of each CHANGELOG.rst, but I don't think there is a necessity to review them in details since they are generated automatically. We can always update them if we notice a package with wrong changelogs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for my pkgs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* unify package.xml version to 0.37.0 Signed-off-by: Yutaka Kondo <[email protected]> * remove system_monitor/CHANGELOG.rst Signed-off-by: Yutaka Kondo <[email protected]> * add changelog Signed-off-by: Yutaka Kondo <[email protected]> * 0.38.0 --------- Signed-off-by: Yutaka Kondo <[email protected]>
* unify package.xml version to 0.37.0 * remove system_monitor/CHANGELOG.rst * add changelog * 0.38.0 --------- Signed-off-by: Yutaka Kondo <[email protected]>
Description
This PR is based on https://github.com/orgs/autowarefoundation/discussions/5292 and aims to manage the versioning of
autowarefoundation/autoware.universe
using ROS package release tools.All package versions have been unified to 0.38.0 following
https://github.com/tier4/autoware.universe/tree/v0.38.0
.Note that this PR is a merge request not for the
main
branch, but for the newly createdhumble
branch. Once this PR is merged, I plan to tag0.38.0
on thehumble
branch and create a PR to merge the differences into themain
branch as well.Currently, I was manually running the ROS package release tools to create PR, but in the future, we would like to modify https://github.com/tier4/autoware-release-scripts to automate this process.
Related links
https://github.com/orgs/autowarefoundation/discussions/5292
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.